codeant-ai-for-open-source[bot] commented on code in PR #41636:
URL: https://github.com/apache/superset/pull/41636#discussion_r3531479557
##########
superset-frontend/packages/superset-core/src/theme/utils/index.ts:
##########
@@ -48,7 +48,7 @@ export function isSerializableConfig(
export function deserializeThemeConfig(
config: SerializableThemeConfig,
): AntdThemeConfig {
- const { algorithm, ...rest } = config;
+ const { algorithm, cssVar, ...rest } = config;
const algorithmMap: Record<string, any> = {
Review Comment:
**Suggestion:** Replace the `any` in the algorithm map type with a concrete
algorithm function type (or a precise union) so the map is fully type-safe.
[custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The rule forbids new or changed TypeScript code from using `any`. This line
introduces `Record<string, any>`, so the violation is real and the suggestion
correctly identifies it.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=eb941619a5f748fa9a17afe4515406c5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=eb941619a5f748fa9a17afe4515406c5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/packages/superset-core/src/theme/utils/index.ts
**Line:** 52:52
**Comment:**
*Custom Rule: Replace the `any` in the algorithm map type with a
concrete algorithm function type (or a precise union) so the map is fully
type-safe.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=12ec7f76a5ff66e59a28258271e7ed98e7d3b38d51ee9612361227cc1312ebbd&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=12ec7f76a5ff66e59a28258271e7ed98e7d3b38d51ee9612361227cc1312ebbd&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
