codeant-ai-for-open-source[bot] commented on code in PR #41636:
URL: https://github.com/apache/superset/pull/41636#discussion_r3531590760
##########
superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts:
##########
@@ -16,13 +16,54 @@
* specific language governing permissions and limitations
* under the License.
*/
-import { LabeledValue as AntdLabeledValue } from 'antd/es/select';
+import {
+ LabeledValue as AntdLabeledValue,
+ SelectProps as AntdSelectProps,
+} from 'antd/es/select';
Review Comment:
**Suggestion:** Replace the direct Ant Design import with the equivalent
type exports from the Superset UI wrapper layer so this code does not depend on
`antd/es/select` directly. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The rule forbids direct frontend imports from Ant Design when Superset UI
core wrappers should be used instead. This file imports `LabeledValue` and
`SelectProps` directly from `antd/es/select`, so the violation is present in
the current code.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=3b3b64ae08414643a379530ea07b2fe6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=3b3b64ae08414643a379530ea07b2fe6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts
**Line:** 19:22
**Comment:**
*Custom Rule: Replace the direct Ant Design import with the equivalent
type exports from the Superset UI wrapper layer so this code does not depend on
`antd/es/select` directly.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=6fee2e3fc2901160568015208a200b3fac7f1dd354f687e8db18ccef1dcd0497&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=6fee2e3fc2901160568015208a200b3fac7f1dd354f687e8db18ccef1dcd0497&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
