rusackas commented on code in PR #41636:
URL: https://github.com/apache/superset/pull/41636#discussion_r3532949260
##########
superset-frontend/packages/superset-core/src/theme/utils/index.ts:
##########
@@ -48,7 +48,7 @@ export function isSerializableConfig(
export function deserializeThemeConfig(
config: SerializableThemeConfig,
): AntdThemeConfig {
- const { algorithm, ...rest } = config;
+ const { algorithm, cssVar, ...rest } = config;
const algorithmMap: Record<string, any> = {
Review Comment:
Good catch, swapped that `any` for antd's `MappingAlgorithm` type.
##########
superset-frontend/packages/superset-ui-core/src/components/Select/styles.tsx:
##########
@@ -54,11 +54,11 @@ export const StyledSelect = styled(Select, {
flex: ${headerPosition === 'left' ? 1 : 0};
line-height: ${theme.sizeXL}px;
- && .ant-select-selection-search {
+ && .ant-select-input {
left: 0px;
}
- && .ant-select-selection-item, .ant-select-selection-placeholder {
+ && .ant-select-content, .ant-select-selection-item,
.ant-select-placeholder {
max-height: ${theme.sizeXL}px;
}
Review Comment:
Good catch, scoped `&&` to all three selectors instead of just the first.
##########
superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts:
##########
@@ -16,13 +16,54 @@
* specific language governing permissions and limitations
* under the License.
*/
-import { LabeledValue as AntdLabeledValue } from 'antd/es/select';
+import {
+ LabeledValue as AntdLabeledValue,
+ SelectProps as AntdSelectProps,
+} from 'antd/es/select';
Review Comment:
This file IS the Select wrapper layer, importing from antd/es/select
directly here is the point - the rest of this directory does the same.
##########
superset-frontend/packages/superset-ui-core/src/components/Collapse/Collapse.test.tsx:
##########
@@ -82,8 +82,10 @@ test('collapses on click', async () => {
await userEvent.click(screen.getAllByRole('button')[0]);
- expect(screen.getByText('Content 1').parentNode).toHaveClass(
- 'ant-collapse-content-hidden',
+ // antd v6 moved the hidden state to the panel wrapper element
+ // (ant-collapse-panel-hidden) instead of the content wrapper.
+ expect(screen.getByText('Content 1').parentElement).toHaveClass(
+ 'ant-collapse-panel-hidden',
);
Review Comment:
jest for this file is green on the current commit with this assertion, so I
think it matches the real antd v6 DOM here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
