codeant-ai-for-open-source[bot] commented on code in PR #41636:
URL: https://github.com/apache/superset/pull/41636#discussion_r3543524545
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts:
##########
@@ -514,15 +514,14 @@ export function inputNativeFilterDefaultValue(
)
.eq(1)
.within(() => {
- cy.get('.ant-select-selection-search-input').type(
- `${defaultValue}{enter}`,
- { force: true },
- );
+ cy.get('.ant-select-input').type(`${defaultValue}{enter}`, {
+ force: true,
+ });
});
});
} else {
cy.getBySel('default-input').within(() => {
- cy.get('.ant-select-selection-search-input').click();
+ cy.get('.ant-select-input').click();
cy.get('.ant-select-item-option-content').contains(defaultValue).click();
});
Review Comment:
**Suggestion:** Use a Playwright click action here instead of Cypress so the
updated E2E flow adheres to the Playwright-only rule. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is new/changed end-to-end test code using Cypress click interactions.
That is a direct violation of the rule requiring Playwright instead of Cypress
in E2E tests.
</details>
<details>
<summary><b>Rule source 📖 </b></summary>
.github/copilot-instructions.md (line 40)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5da0016863c14970beb4e96584fb6de2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5da0016863c14970beb4e96584fb6de2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts
**Line:** 523:526
**Comment:**
*Custom Rule: Use a Playwright click action here instead of Cypress so
the updated E2E flow adheres to the Playwright-only rule.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=dbd57fb9ef0a42f699f3bb039e6f70ce7590d4a10c08ac8c7a053463c2cb90f3&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=dbd57fb9ef0a42f699f3bb039e6f70ce7590d4a10c08ac8c7a053463c2cb90f3&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
