rusackas commented on code in PR #41636:
URL: https://github.com/apache/superset/pull/41636#discussion_r3557699622
##########
superset-frontend/src/explore/components/controls/SelectControl.test.tsx:
##########
@@ -414,8 +410,9 @@ describe('SelectControl', () => {
// The SelectControl should receive a sortComparator for numeric values
// This is tested by verifying the component renders without errors
+ // antd v6 places the aria-label on the Select's input element.
const selectorWrapper = screen.getByLabelText('Row Limit', {
- selector: 'div',
+ selector: 'input',
});
expect(selectorWrapper).toBeInTheDocument();
Review Comment:
The `getSortComparator` logic itself is already unit-tested directly above
this block, so this one is intentionally just a render smoke test on top of
that coverage. Leaving as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
