rusackas commented on code in PR #41636:
URL: https://github.com/apache/superset/pull/41636#discussion_r3543529577
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts:
##########
@@ -514,15 +514,14 @@ export function inputNativeFilterDefaultValue(
)
.eq(1)
.within(() => {
- cy.get('.ant-select-selection-search-input').type(
- `${defaultValue}{enter}`,
- { force: true },
- );
+ cy.get('.ant-select-input').type(`${defaultValue}{enter}`, {
+ force: true,
+ });
});
});
} else {
cy.getBySel('default-input').within(() => {
- cy.get('.ant-select-selection-search-input').click();
+ cy.get('.ant-select-input').click();
cy.get('.ant-select-item-option-content').contains(defaultValue).click();
});
Review Comment:
This is just an existing Cypress selector getting updated for antd v6, not
new Cypress code, so the Playwright-only rule doesn't apply here. Migrating
this whole dashboard suite to Playwright is out of scope for an antd upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
