bito-code-review[bot] commented on code in PR #41636:
URL: https://github.com/apache/superset/pull/41636#discussion_r3553622646
##########
superset-frontend/src/explore/components/controls/SelectControl.test.tsx:
##########
@@ -414,8 +410,9 @@ describe('SelectControl', () => {
// The SelectControl should receive a sortComparator for numeric values
// This is tested by verifying the component renders without errors
+ // antd v6 places the aria-label on the Select's input element.
const selectorWrapper = screen.getByLabelText('Row Limit', {
- selector: 'div',
+ selector: 'input',
});
expect(selectorWrapper).toBeInTheDocument();
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incomplete test assertion coverage</b></div>
<div id="fix">
This test named 'applies numeric sorting to choices automatically' only
verifies the component renders, not that sorting actually occurred. Add
assertion to verify sorted order (e.g., check option elements appear in numeric
order).
</div>
</div>
<small><i>Code Review Run #a3c8ff</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
