jesperct opened a new pull request, #41912: URL: https://github.com/apache/superset/pull/41912
### SUMMARY Clicking a saved query card on the home page did nothing. No navigation, no feedback. The SqlLab SPA migration (#25151) removed the `onClick` handler on the card wrapper that used to open the query in SQL Lab, leaving only a `url` prop on `ListViewCard`. That `url` only turns into a link when the card renders its fallback cover, which `SavedQueries` never does because it always passes a custom `cover`. So the card ended up with no navigation at all, while `cursor: pointer` still made it look clickable. This restores navigation the same way `ChartCard` and `DashboardCard` already do it: an `onClick` on the card wrapper that pushes to `/sqllab?savedQueryId=<id>`. `history.push` goes through the router `basename`, so it also works under a prefixed (subdirectory) deployment. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before, clicking the card stayed on the home page:  After, clicking the card opens the query in SQL Lab:  ### TESTING INSTRUCTIONS 1. Create a saved query (SQL Lab, write a query, Save). 2. Go to the home page and expand the "Saved queries" section. 3. Click the saved query card. 4. It should open the query in SQL Lab. A unit test was added in `SavedQueries.test.tsx` that asserts the card navigates to `/sqllab?savedQueryId=<id>`. ### ADDITIONAL INFORMATION - [x] Changes UI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
