bito-code-review[bot] commented on PR #41912:
URL: https://github.com/apache/superset/pull/41912#issuecomment-4929632907
<!-- Bito Reply -->
The suggestion to replace the `any` type in the `renderSavedQueries` helper
is correct, as it improves type safety by ensuring the helper accepts only the
props expected by the `SavedQueries` component. You can resolve this by
importing the component's props type (e.g., `React.ComponentProps<typeof
SavedQueries>`) and using it instead of `any`.
There are no other comments on this PR to address.
**superset-frontend/src/features/home/SavedQueries.test.tsx**
```
const renderSavedQueries = (props: React.ComponentProps<typeof
SavedQueries>) =>
act(async () => {
render(<SavedQueries {...props} />, { useRedux: true, useRouter: true });
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
