bito-code-review[bot] commented on code in PR #41636:
URL: https://github.com/apache/superset/pull/41636#discussion_r3568456090
##########
superset-frontend/src/features/alerts/AlertReportModal.test.tsx:
##########
@@ -1853,7 +1889,7 @@ test('filter reappears in dropdown after clearing with X
icon', async () => {
await waitFor(() => {
const selectionItem = document.querySelector(
- '.ant-select-selection-item[title="Test Filter 1"]',
+ '.ant-select-content-has-value[title="Test Filter 1"],
.ant-select-selection-item[title="Test Filter 1"]',
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>SEMANTIC_DUPLICATION: Repeated selector pattern</b></div>
<div id="fix">
Six locations repeat the same 72-character selector pattern verbatim.
Extract this into a reusable constant (e.g., `SELECTED_VALUE_SELECTOR`) near
line 398 where `comboboxSelect` is defined. This prevents divergence risk if
the selector structure changes with future antd versions. Similar patterns
already exist at lines 1180 and 1197 without extraction.
</div>
</div>
<small><i>Code Review Run #bc3ba2</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
