bito-code-review[bot] commented on code in PR #41636:
URL: https://github.com/apache/superset/pull/41636#discussion_r3568617806
##########
superset-frontend/src/features/alerts/AlertReportModal.test.tsx:
##########
@@ -1853,7 +1889,7 @@ test('filter reappears in dropdown after clearing with X
icon', async () => {
await waitFor(() => {
const selectionItem = document.querySelector(
- '.ant-select-selection-item[title="Test Filter 1"]',
+ '.ant-select-content-has-value[title="Test Filter 1"],
.ant-select-selection-item[title="Test Filter 1"]',
Review Comment:
<!-- Bito Reply -->
The extraction of the selector into a reusable constant is a positive
improvement. It centralizes the selector logic, which reduces maintenance
overhead and minimizes the risk of divergence if the underlying structure
changes in future versions.
**superset-frontend/src/features/alerts/AlertReportModal.test.tsx**
```
await waitFor(() => {
const selectionItem = document.querySelector(
'.ant-select-content-has-value[title="Test Filter 1"],
.ant-select-selection-item[title="Test Filter 1"]',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
