rusackas commented on code in PR #41636:
URL: https://github.com/apache/superset/pull/41636#discussion_r3565152901
##########
superset-frontend/cypress-base/cypress/support/directories.ts:
##########
@@ -338,20 +338,20 @@ export const nativeFilters = {
filtersPanel: {
filterName: dataTestLocator('filters-config-modal__name-input'),
datasetName: dataTestLocator('filters-config-modal__datasource-input'),
- filterInfoInput: '.ant-select-selection-search-input',
+ filterInfoInput: '.ant-select-input',
inputDropdown: '.ant-select-item-option-content',
- columnEmptyInput: '.ant-select-selection-placeholder',
+ columnEmptyInput: '.ant-select-placeholder',
filterTypeInput: dataTestLocator('filters-config-modal__filter-type'),
fieldInput: dataTestLocator('field-input'),
- filterTypeItem: '.ant-select-selection-item',
+ filterTypeItem: '.ant-select-content-has-value,
.ant-select-selection-item',
filterGear: dataTestLocator('filterbar-orientation-icon'),
},
filterFromDashboardView: {
- filterValueInput: '[class="ant-select-selection-search-input"]',
+ filterValueInput: '.ant-select-input',
Review Comment:
This isn't a new Cypress locator, it's an existing one being updated to
match antd6's renamed classes (`ant-select-selection-search-input` ->
`ant-select-input`, etc). Migrating this suite to Playwright is a separate
effort, out of scope here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
