codeant-ai-for-open-source[bot] commented on code in PR #41636:
URL: https://github.com/apache/superset/pull/41636#discussion_r3564093577
##########
superset-frontend/cypress-base/cypress/support/directories.ts:
##########
@@ -338,20 +338,20 @@ export const nativeFilters = {
filtersPanel: {
filterName: dataTestLocator('filters-config-modal__name-input'),
datasetName: dataTestLocator('filters-config-modal__datasource-input'),
- filterInfoInput: '.ant-select-selection-search-input',
+ filterInfoInput: '.ant-select-input',
inputDropdown: '.ant-select-item-option-content',
- columnEmptyInput: '.ant-select-selection-placeholder',
+ columnEmptyInput: '.ant-select-placeholder',
filterTypeInput: dataTestLocator('filters-config-modal__filter-type'),
fieldInput: dataTestLocator('field-input'),
- filterTypeItem: '.ant-select-selection-item',
+ filterTypeItem: '.ant-select-content-has-value,
.ant-select-selection-item',
filterGear: dataTestLocator('filterbar-orientation-icon'),
},
filterFromDashboardView: {
- filterValueInput: '[class="ant-select-selection-search-input"]',
+ filterValueInput: '.ant-select-input',
Review Comment:
**Suggestion:** Replace this new Cypress filter locator entry with a
Playwright locator in the corresponding Playwright test utilities. [custom_rule]
**Severity Level:** Major ⚠️
<details>
<summary><b>Why it matters? ⭐ </b></summary>
This is a new Cypress selector definition in an E2E support file. The custom
rule prefers Playwright for new or changed E2E test code, so the suggestion
correctly identifies a violation.
</details>
<details>
<summary><b>Rule source 📖 </b></summary>
.github/copilot-instructions.md (line 40)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=4dd448437f584231bd3db53b6bbca78c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=4dd448437f584231bd3db53b6bbca78c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/cypress-base/cypress/support/directories.ts
**Line:** 350:350
**Comment:**
*Custom Rule: Replace this new Cypress filter locator entry with a
Playwright locator in the corresponding Playwright test utilities.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=c53000f4043029adf8a5723a45f2cb134cefa1993be63aab5e148a11894bc8f1&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=c53000f4043029adf8a5723a45f2cb134cefa1993be63aab5e148a11894bc8f1&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
