rusackas commented on PR #40635: URL: https://github.com/apache/superset/pull/40635#issuecomment-5013086166
Thanks for the fast turnaround here, and sorry, I think I may have sent you down the wrong path on the `%` entries earlier. I ran `pybabel compile` against the branch and `% of parent`/`% of total` still fail to compile (`incompatible format for placeholder 1: 'o' and 'd' are not compatible`), which is the exact error you originally hit. Turns out `no-python-format` doesn't actually suppress Babel's format check once an entry is confirmed (non-fuzzy), it re-derives `python_format` from a regex over the msgid regardless of that flag, and `% of parent`/`% du parent` happen to parse as `%o` vs `%d`. `% calculation` dodges it by luck since both sides parse as `%c`. Since neither `%%` (breaks the runtime `t()` lookup) nor plain `%` (breaks compile once un-fuzzied) is safe here, I think the least-dangerous move is leaving those two entries fuzzy like they are on `master` for now, that's status quo, not a regression. `% calculation` is fine to keep confirmed. Sorry, that's a mouthful of a review, and this stuff gets a bit tricky... let me know if you want me to jump in with any commits to clean up and get this across the finish line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
