codeant-ai-for-open-source[bot] commented on code in PR #40635: URL: https://github.com/apache/superset/pull/40635#discussion_r3608672934
########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -1746,9 +1738,8 @@ msgstr "Une erreur s'est produite durant l'accès à l'extension." msgid "An error occurred while accessing the value." msgstr "Une erreur s'est produite durant l'accès à la valeur." -#, fuzzy msgid "An error occurred while adding semantic views" -msgstr "Une erreur s'est produite durant le chargement de SQL" +msgstr "Une erreur s'est produite lors du chargement de SQL" Review Comment: **Suggestion:** The French translation points to SQL loading instead of semantic views, which gives users the wrong failure context. Update this translation to reference semantic views so the displayed error matches the actual operation that failed. [logic error] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx ⚠️ French semantic-view errors look like SQL load failures. ⚠️ Misleading error text complicates semantic-view troubleshooting. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Configure Superset to use the French locale so strings are loaded from `superset/translations/fr/LC_MESSAGES/messages.po` (see line 1741 `msgid "An error occurred while adding semantic views"` and line 1742 `msgstr "Une erreur s'est produite lors du chargement de SQL"` in the PR diff). 2. From the semantic layer UI (semantic view management screen wired to the backend error `An error occurred while adding semantic views`), attempt to add or save a semantic view in a way that triggers a backend error (for example, by causing a validation failure or server-side exception). 3. The backend returns the msgid `An error occurred while adding semantic views`, which the i18n system looks up in `messages.po` and displays the French msgstr from line 1742. 4. Observe that the toast/dialog in the French UI says \"Une erreur s'est produite lors du chargement de SQL\", incorrectly referring to SQL loading instead of semantic views, giving users the wrong context for the failure. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=ca0f27637aa040539495745ce29c6650&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=ca0f27637aa040539495745ce29c6650&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/fr/LC_MESSAGES/messages.po **Line:** 1742:1742 **Comment:** *Logic Error: The French translation points to SQL loading instead of semantic views, which gives users the wrong failure context. Update this translation to reference semantic views so the displayed error matches the actual operation that failed. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40635&comment_hash=eb8df72df6df28fa075c010241346ccdc1aed146dc67d7f7d03037689d1308c0&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40635&comment_hash=eb8df72df6df28fa075c010241346ccdc1aed146dc67d7f7d03037689d1308c0&reaction=dislike'>👎</a> ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -1917,36 +1902,34 @@ msgstr "" msgid "An error occurred while fetching schema values: %s" msgstr "Une erreur s'est produite lors de l'extraction des valeurs du schéma : %s" -#, fuzzy msgid "An error occurred while fetching semantic layer types" -msgstr "Une erreur s'est produite lors de l'extraction des Thèmes " +msgstr "Une erreur s'est produite lors de la récupération des Thèmes " -#, fuzzy msgid "An error occurred while fetching semantic layers" -msgstr "Une erreur s'est produite lors de l'extraction des valeurs du schéma : %s" +msgstr "Une erreur s'est produite lors de la récupération des couches sémantiques" msgid "An error occurred while fetching tab state" msgstr "Une erreur s'est produite lors de l'extraction de l'état de l'onglet" -#, fuzzy, python-format +#, python-format msgid "An error occurred while fetching table metadata for %s" -msgstr "Une erreur s'est produite lors de l'extraction des métadonnées du tableau" +msgstr "" +"Une erreur s'est produite lors de l'extraction des métadonnées de la " +"table pour %s" -#, fuzzy msgid "An error occurred while fetching the configuration schema" -msgstr "Une erreur s'est produite lors de la recherche des noms de fonctions." +msgstr "" +"Une erreur s'est produite lors de la récupération des schémas de " +"configuration." -#, fuzzy msgid "An error occurred while fetching the runtime schema" -msgstr "Une erreur s'est produite lors de la recherche des noms de fonctions." +msgstr "Une erreur s'est produite lors de la récupération des schéma d'exécution." -#, fuzzy msgid "An error occurred while fetching the semantic layer" -msgstr "Une erreur s'est produite lors de l'extraction de l'état de l'onglet" +msgstr "Une erreur s'est produite lors de la récupération de l'état de l'onglet" -#, fuzzy msgid "An error occurred while fetching the semantic view structure" -msgstr "Une erreur s'est produite lors de l'extraction de l'état de l'onglet" +msgstr "Une erreur s'est produite lors de la récupération de l'état de l'onglet" #, python-format Review Comment: **Suggestion:** This translation says the system failed to fetch tab state, but the source message is about fetching the semantic layer. Replace it with a semantic-layer-specific translation to avoid misleading troubleshooting information. [logic error] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx ⚠️ Semantic-layer fetch errors misreported as tab-state issues. ⚠️ French users search tab problems instead of semantic layer. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Enable the French locale so errors use `superset/translations/fr/LC_MESSAGES/messages.po`, specifically the entry around line 1933 `msgid "An error occurred while fetching the semantic layer"` with line 1934 `msgstr "Une erreur s'est produite lors de la récupération de l'état de l'onglet"`. 2. From the semantic layer management UI, trigger a failure while fetching the semantic layer (for example, by opening a semantic layer that causes a backend exception in the semantic-layer fetch endpoint). 3. The backend surfaces the msgid `An error occurred while fetching the semantic layer`, which the i18n subsystem resolves against `messages.po` and returns the French msgstr from line 1934. 4. In the French UI, observe the error text \"Une erreur s'est produite lors de la récupération de l'état de l'onglet\", which incorrectly mentions tab state instead of the semantic layer, giving users the wrong feature area to investigate. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=95fb9fa01963492ab856547655ebda03&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=95fb9fa01963492ab856547655ebda03&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/fr/LC_MESSAGES/messages.po **Line:** 1934:1934 **Comment:** *Logic Error: This translation says the system failed to fetch tab state, but the source message is about fetching the semantic layer. Replace it with a semantic-layer-specific translation to avoid misleading troubleshooting information. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40635&comment_hash=58b0f99f712e80211e1267219e0cce33437eb23fd0663351d2fe7c04f11863a8&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40635&comment_hash=58b0f99f712e80211e1267219e0cce33437eb23fd0663351d2fe7c04f11863a8&reaction=dislike'>👎</a> ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -16862,23 +16045,23 @@ msgid "" "and 180° draws a half donut. When the sweep is 180° or less and the start" " angle is a multiple of 90°, the chart is automatically re-centered to " "make use of the empty space." -msgstr "" +msgstr "Angle total de couverture du graphique, en degrés. 360° dessine un " +"cercle entier et 180° dessine un demi-donut. Quand l'arc est de 180° ou moins " +"et que le début de l'angle est un multiple de 90°, the graphique est " +"automatiquement recentré pour utiliser tout l'espace vide." -#, fuzzy msgid "Total color" -msgstr "Couleur du point" +msgstr "Couleur total" -#, fuzzy msgid "Total label" -msgstr "Valeur totale" +msgstr "Etiquette totale" -#, fuzzy msgid "Total value" msgstr "Valeur totale" Review Comment: **Suggestion:** The French string changes the action from opening SQL Lab in a new tab to executing a query in a new tab, which is not equivalent. Align the translation with the original UI action to avoid behavioral confusion. [logic error] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx ⚠️ Action label suggests execution instead of opening workspace. ⚠️ French users may misinterpret SQL Lab navigation. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Enable the French locale so UI strings come from `superset/translations/fr/LC_MESSAGES/messages.po`, particularly the entry around line 16059 where the msgid refers to opening SQL Lab (e.g. `msgid "Open SQL Lab in a new tab"` or similar) but line 16060 has `msgstr "Exécuter la requête dans un nouvel onglet"`. 2. From a chart or dataset view that exposes a \"Open SQL Lab in a new tab\" action (the control that should open the SQL Lab workspace with the query preloaded), open the action menu in the French UI. 3. Observe that the French label for that action is \"Exécuter la requête dans un nouvel onglet\", which describes executing the query rather than opening SQL Lab. 4. Click the action and see that the behavior is to open the SQL Lab editor, not to immediately run the query, demonstrating that the translation changed semantics and can mislead users about what will happen. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=d7a397fde79445e3b92100a0065c9320&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=d7a397fde79445e3b92100a0065c9320&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/fr/LC_MESSAGES/messages.po **Line:** 16060:16060 **Comment:** *Logic Error: The French string changes the action from opening SQL Lab in a new tab to executing a query in a new tab, which is not equivalent. Align the translation with the original UI action to avoid behavioral confusion. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40635&comment_hash=bcad89ce31d531b66f065d85cbf29a23b52340ff06c9b21e67728ed6c7b5273c&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40635&comment_hash=bcad89ce31d531b66f065d85cbf29a23b52340ff06c9b21e67728ed6c7b5273c&reaction=dislike'>👎</a> ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -4966,63 +4869,63 @@ msgstr "" "table avant de restaurer." msgid "Dataset column delete failed." -msgstr "La suppression de l’ensemble de données a échoué." +msgstr "La suppression du jeu de données a échoué." Review Comment: **Suggestion:** This translation says dataset deletion failed, but the source text is specifically about dataset column deletion. Use a column-specific translation to preserve the correct scope of the failure. [logic error] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx ⚠️ Column-delete failure reported as dataset-delete failure. ⚠️ French users fear dataset loss instead of column issue. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Ensure French translations are active so `superset/translations/fr/LC_MESSAGES/messages.po` is used, focusing on the entry where line 4871 is `msgid "Dataset column delete failed."` and line 4872 is `msgstr "La suppression du jeu de données a échoué."`. 2. In the dataset editor UI, attempt to delete a single dataset column (for example, removing a derived column) in a way that causes the backend column-delete operation to fail (validation error or server-side failure). 3. The backend returns the msgid `Dataset column delete failed.`, which the translation system maps to the French msgstr at line 4872. 4. Observe that the French UI error says \"La suppression du jeu de données a échoué.\", implying the dataset itself failed to delete instead of only the column, overstating the scope and confusing the user about what went wrong. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=66b7cba265544f7baa1e522db20cdf04&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=66b7cba265544f7baa1e522db20cdf04&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/fr/LC_MESSAGES/messages.po **Line:** 4872:4872 **Comment:** *Logic Error: This translation says dataset deletion failed, but the source text is specifically about dataset column deletion. Use a column-specific translation to preserve the correct scope of the failure. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40635&comment_hash=85976f01a9f52f9b08fb82dd7e07dfaec5833bafafdac6a7308f76e9e712663f&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40635&comment_hash=85976f01a9f52f9b08fb82dd7e07dfaec5833bafafdac6a7308f76e9e712663f&reaction=dislike'>👎</a> ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -1917,36 +1902,34 @@ msgstr "" msgid "An error occurred while fetching schema values: %s" msgstr "Une erreur s'est produite lors de l'extraction des valeurs du schéma : %s" -#, fuzzy msgid "An error occurred while fetching semantic layer types" -msgstr "Une erreur s'est produite lors de l'extraction des Thèmes " +msgstr "Une erreur s'est produite lors de la récupération des Thèmes " Review Comment: **Suggestion:** The translation for semantic layer type fetching currently mentions themes, which is a different feature. Correct this string to mention semantic layer types so users get accurate error feedback. [logic error] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx ⚠️ Semantic-layer-type failures appear as theme load errors. ⚠️ Troubleshooting efforts diverted to theme configuration. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Use the French locale so errors come from `superset/translations/fr/LC_MESSAGES/messages.po`, in particular the entry at line 1905 `msgid "An error occurred while fetching semantic layer types"` with line 1906 `msgstr "Une erreur s'est produite lors de la récupération des Thèmes "`. 2. From the semantic-layer type configuration UI (where the frontend calls into the backend to fetch available semantic layer types), perform an action that causes the semantic-layer-type fetch to fail (for example, misconfiguring the backend so the endpoint errors). 3. The backend returns the msgid `An error occurred while fetching semantic layer types`, which is translated via `messages.po` into the French msgstr defined on line 1906. 4. In the French UI, observe the error \"Une erreur s'est produite lors de la récupération des Thèmes\", which incorrectly talks about themes instead of semantic layer types, misleading users toward theme configuration rather than semantic-layer-type troubleshooting. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5e3d45ca52264bb098fa0548d8db0332&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5e3d45ca52264bb098fa0548d8db0332&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/fr/LC_MESSAGES/messages.po **Line:** 1906:1906 **Comment:** *Logic Error: The translation for semantic layer type fetching currently mentions themes, which is a different feature. Correct this string to mention semantic layer types so users get accurate error feedback. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40635&comment_hash=aed757cb50dc3b95f3f7777db8e69da9f80c471c3f86301afe4471aa89e5b0c7&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40635&comment_hash=aed757cb50dc3b95f3f7777db8e69da9f80c471c3f86301afe4471aa89e5b0c7&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
