rusackas commented on PR #42157: URL: https://github.com/apache/superset/pull/42157#issuecomment-5028697500
Thanks @jenwitteng, solid diagnosis on the 202 handling and good hardening around supersession/abort. Main thing that stops me from approving: `asyncEvent.test.ts` drops several tests that are still exercising code on `master`, the polling backoff/cap tests, the re-init dedup test, and the CodeQL prototype-pollution regression guard for reserved `job_id` keys like `__proto__`. None of that underlying code got removed, so this reads like it got lost in the rebase the same way the other guards you already restored were. Losing the security regression guard especially worries me, can you bring those back? Codeant's threads on the `any` casts in the new test file are still open too, worth cleaning up per the no-any convention. Also `pre-commit` is failing on CI, looks like `oxlint` wants to auto-fix something that didn't get committed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
