bito-code-review[bot] commented on code in PR #42157:
URL: https://github.com/apache/superset/pull/42157#discussion_r3619804026
##########
superset-frontend/src/components/Chart/ChartRenderer.tsx:
##########
@@ -385,6 +395,10 @@ function ChartRendererComponent({
setDataMask: setDataMaskCallback,
onLegendScroll: handleLegendScroll,
onChartStateChange,
+ // Lets self-contained chart components in superset-ui-core (e.g.
+ // StatefulChart) resolve async (202) chart-data responses without
+ // depending on app-level async-event middleware.
+ handleAsyncChartData: handleChartDataResponse,
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to remove `handleChartDataResponse` from the
`useMemo` dependency array is correct. As you noted, outer scope values that do
not trigger re-renders when mutated should not be included in dependency
arrays, as including them can lead to unnecessary re-computations or stale
closures. Your decision to revert the addition after verifying with the
project's linting tools is the appropriate action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
