rusackas commented on PR #42157: URL: https://github.com/apache/superset/pull/42157#issuecomment-5037548231
Thanks @jenwitteng, this is in much better shape now. The dropped `asyncEvent.test.ts` tests are back (backoff/cap, re-init dedup, the `__proto__` regression guard), the `any` casts in `StatefulChart.test.tsx` are gone, and the oxlint fix landed. Nice! One thing before I approve, though. The new `GlobalAsyncQueries` error handling you added in `exploreJSON` (the array vs. error-object vs. raw-response split in `chartAction.ts`) doesn't look like it has a test yet, and that's exactly the kind of branch that can be subtly wrong. If you could add a case or two around it, that'd be appreciated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
