jenwitteng commented on code in PR #42157:
URL: https://github.com/apache/superset/pull/42157#discussion_r3619803237
##########
superset-frontend/src/components/Chart/ChartRenderer.tsx:
##########
@@ -385,6 +395,10 @@ function ChartRendererComponent({
setDataMask: setDataMaskCallback,
onLegendScroll: handleLegendScroll,
onChartStateChange,
+ // Lets self-contained chart components in superset-ui-core (e.g.
+ // StatefulChart) resolve async (202) chart-data responses without
+ // depending on app-level async-event middleware.
+ handleAsyncChartData: handleChartDataResponse,
Review Comment:
react-hooks(exhaustive-deps): React Hook useMemo has an unnecessary
dependency: handleChartDataResponse.
help: Consider removing it from the dependency array. Outer scope values
aren't valid dependencies because mutating them doesn't re-render the component.
I had it backwards for a moment — I added it to satisfy CodeAnt, then
oxlint (the tool actually enforced by this repo's pre-commit) told me that
addition was itself wrong, so I reverted it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
