michael-s-molina commented on code in PR #39171: URL: https://github.com/apache/superset/pull/39171#discussion_r3622997140
########## superset-core/src/superset_core/extensions/context.py: ########## @@ -0,0 +1,136 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Extension Context API for superset-core extensions. + +Provides access to the current extension's context, including metadata +and scoped resources like storage. Extensions call `get_context()` to +access their context during execution. + +The context is set by the host (Superset) during extension loading and +is only available within extension code. + +Usage: + from superset_core.extensions.context import get_context + + def setup(): + ctx = get_context() + + # Access extension metadata + print(f"Running {ctx.extension.displayName} v{ctx.extension.version}") + + # Access extension-scoped storage + ctx.storage.ephemeral.set("lastRun", time.time()) + data = ctx.storage.ephemeral.get("cachedData") Review Comment: Fixed — added `EphemeralSetOptions(ttl=3600)` to the example. ########## superset/extensions/storage/persistent_model.py: ########## @@ -0,0 +1,133 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import uuid as uuid_module + +from flask_appbuilder import Model +from sqlalchemy import ( + Boolean, + Column, + ForeignKey, + Index, + Integer, + LargeBinary, + String, + UniqueConstraint, +) +from sqlalchemy_utils import UUIDType +from superset_core.extensions.storage.models import ( + ExtensionStorageEntry as CoreExtensionStorageEntry, +) + +from superset.models.helpers import AuditMixinNullable + + +class ExtensionStorage(CoreExtensionStorageEntry, AuditMixinNullable, Model): + """Generic persistent key-value storage for extensions (Tier 3). + + Each row is identified by (extension_id, user_fk, resource_type, + resource_uuid, key): + + * Global scope — user_fk IS NULL, resource_type IS NULL + * User scope — user_fk set, resource_type IS NULL + * Resource scope — resource_type + resource_uuid set (user_fk optional) + + The payload is stored as raw bytes (value) alongside the identifier of + the codec used to encode it (codec), so the same bytes can be decoded + back into a value on read. When is_encrypted is True the value has been + encrypted at the DAO layer using Fernet and must be decrypted before + decoding. + """ + + __tablename__ = "extension_storage" + + id = Column(Integer, primary_key=True, autoincrement=True) + uuid = Column( + UUIDType(binary=True), + default=uuid_module.uuid4, + unique=True, + nullable=False, + ) + + # Extension identity + extension_id = Column(String(255), nullable=False) + + # Scope discriminators — all nullable; NULLs define the scope (see docstring). + # No relationship() is declared for user_fk: extension storage rows are + # not deleted when their owning user is (ondelete="SET NULL" demotes them + # to global scope instead), and nothing reads through such a relationship, + # so there's no ORM object here for a future change to attach a cascade to. + user_fk = Column( + Integer, + ForeignKey( + "ab_user.id", + ondelete="SET NULL", + name="fk_extension_storage_user_fk_ab_user", + ), + nullable=True, + ) + # No FK here: resource_type is a free-form string naming the referenced + # table (a built-in Superset model or a resource type defined by another + # extension entirely), so the table a given row's resource_uuid points + # into varies per row and can't be fixed at the schema level. + resource_type = Column(String(64), nullable=True) + resource_uuid = Column(String(36), nullable=True) + + # Storage key within the scope + key = Column(String(255), nullable=False) + + # Payload. Size is bounded at the application level by + # EXTENSIONS_PERSISTENT_STORAGE["MAX_VALUE_SIZE"], enforced in + # ExtensionStorageDAO.set(), rather than by a fixed column length here. + value = Column(LargeBinary, nullable=False) + # Byte length of `value`, kept in sync at write time so the quota SUM in + # _check_quota() can be computed from this fixed-width column instead of + # reading (and, once TOASTed, detoasting) every extension's stored blobs. + value_size = Column(Integer, nullable=False) + codec = Column(String(255), nullable=False, default="json") + is_encrypted = Column(Boolean, nullable=False, default=False) + + __table_args__ = ( + # Unique constraint prevents duplicate rows from concurrent writes + UniqueConstraint( + "extension_id", + "user_fk", + "resource_type", + "resource_uuid", + "key", + name="uq_extension_storage_scoped_key", + ), Review Comment: Not changing the schema — partial/filtered unique indexes aren't portable to MySQL (no support at all), and sentinel values for `user_fk` would mean giving up its FK + `ondelete=SET NULL` auto-demotion-to-global-scope semantics. Concurrent writes to the same key are instead serialized by the `DistributedLock` in `ExtensionStorageDAO.set()`. The one real gap — `ExtensionStorageDAO.create()` bypassing that lock entirely — is closed separately: `create()` now raises `NotImplementedError` directing callers to `.set()`, since it never had upsert/validation/locking semantics to begin with. ########## superset/extensions/storage/api.py: ########## @@ -0,0 +1,738 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +REST API for extension storage. + +Provides HTTP endpoints for frontend extensions to access server-side +ephemeral storage without direct backend code. + +All operations are user-scoped by default. Use `?shared=true` query param +to access shared state visible to all users. +""" + +from __future__ import annotations + +import base64 +from typing import Any + +from flask import g, request +from flask.wrappers import Response +from flask_appbuilder.api import BaseApi, expose, protect, safe + +from superset.extensions.storage.codecs import DEFAULT_CODEC, get_codec, SAFE_CODECS +from superset.extensions.storage.ephemeral_dao import ( + ExtensionEphemeralDAO, + ExtensionEphemeralTTLInvalid, + ExtensionEphemeralValueTooLarge, +) +from superset.extensions.storage.persistent_dao import ( + ExtensionStorageDAO, + ExtensionStorageKeyTooLong, + ExtensionStorageListPayloadTooLarge, + ExtensionStorageQuotaExceeded, + ExtensionStorageValueTooLarge, +) +from superset.extensions.storage.utils import get_extension_or_404, parse_ttl +from superset.key_value.exceptions import KeyValueCodecEncodeException +from superset.utils.decorators import transaction + + +def _decoded_result_for_wire(decoded: Any) -> tuple[Any, bool]: + """Convert a codec-decoded value into its JSON wire representation. + + JSON has no byte type, so a raw `bytes` value is base64-encoded to a + string for the response and flagged as such; every other value is + already JSON-representable as-is. Checked on the decoded value's + actual type, not the codec's name, so this keeps working for a codec + this module didn't define. + + :returns: (wire_value, is_binary) + """ + if isinstance(decoded, bytes): + return base64.b64encode(decoded).decode("ascii"), True + return decoded, False + + +def _wire_value_for_request(value: Any, is_binary: bool) -> Any: + """Convert a request body's JSON `value` into a codec's input type. + + `is_binary` is an explicit flag from the caller: JSON has no byte + type, so there is no way to tell, from the JSON `value` alone, + whether it is a base64 string that must be decoded to bytes before + being handed to the codec's `encode`, or a literal value to pass + through as-is. Only the caller knows which it sent. + + :raises ValueError: if `is_binary` is set and `value` is not a valid + base64 string. + """ + if is_binary: + return base64.b64decode(value, validate=True) + return value + + +class ExtensionStorageRestApi(BaseApi): + """REST API for extension ephemeral (Tier 2) and persistent (Tier 3) storage.""" + + allow_browser_login = True + route_base = "/api/v1/extensions" + + def response(self, status_code: int, **kwargs: Any) -> Response: + """Helper method to create JSON responses.""" + from flask import jsonify + + return jsonify(kwargs), status_code + + def response_404(self, message: str = "Not found") -> Response: + """Helper method to create 404 responses.""" + from flask import jsonify + + return jsonify({"message": message}), 404 + + def response_400(self, message: str) -> Response: + """Helper method to create 400 responses.""" + from flask import jsonify + + return jsonify({"message": message}), 400 + + @protect() + @safe + @expose("/<publisher>/<name>/storage/ephemeral/<key>", methods=("GET",)) + def get_ephemeral( + self, publisher: str, name: str, key: str, **kwargs: Any + ) -> Response: + """Get a value from ephemeral state. + --- + get: + summary: Get a value from ephemeral state + parameters: + - in: path + name: publisher + schema: + type: string + required: true + description: Extension publisher + - in: path + name: name + schema: + type: string + required: true + description: Extension name + - in: path + name: key + schema: + type: string + required: true + description: Storage key + - in: query + name: shared + schema: + type: boolean + required: false + description: If true, read from shared state visible to all users + responses: + 200: + description: Value retrieved successfully + content: + application/json: + schema: + type: object + properties: + result: + description: The stored value. When 'isBinary' is + true, this is a base64 string that must be + decoded to get the actual value. + codec: + type: string + description: Name of the codec 'result' was encoded + with, e.g. "json" (default) or "binary" + isBinary: + type: boolean + description: Whether the stored value is binary + data + 400: + description: Value was stored with a codec unavailable over the API + 404: + description: Extension not found + """ + extension_id = f"{publisher}.{name}" + extension = get_extension_or_404(extension_id) + if not extension: + return self.response_404("Extension not found") + + shared = request.args.get("shared", "false").lower() == "true" + raw = ExtensionEphemeralDAO.get_raw(extension_id, key, shared=shared) + if raw is None: + return self.response(200, result=None) + value, codec = raw + if codec not in SAFE_CODECS: + return self.response_400( + f"Value was stored with codec '{codec}', which cannot be " + "read over the REST API." + ) + + result, is_binary = _decoded_result_for_wire(get_codec(codec).decode(value)) + return self.response(200, result=result, codec=codec, isBinary=is_binary) + + @protect() + @safe + @expose("/<publisher>/<name>/storage/ephemeral/<key>", methods=("PUT",)) + def set_ephemeral( + self, publisher: str, name: str, key: str, **kwargs: Any + ) -> Response: + """Set a value in ephemeral state. + --- + put: + summary: Set a value in ephemeral state + parameters: + - in: path + name: publisher + schema: + type: string + required: true + description: Extension publisher + - in: path + name: name + schema: + type: string + required: true + description: Extension name + - in: path + name: key + schema: + type: string + required: true + description: Storage key + - in: query + name: shared + schema: + type: boolean + required: false + description: If true, store as shared state visible to all users + requestBody: + required: true + content: + application/json: + schema: + type: object + required: + - value + - ttl + properties: + value: + description: The value to store (must not exceed + MAX_VALUE_SIZE bytes once encoded with 'codec'). + When 'isBinary' is true, this must be a base64 + string, decoded before being handed to 'codec'. + codec: + type: string + description: Name of the codec used to encode 'value', + e.g. "json" (default). Must be one of the codecs + allowed over the REST API. + isBinary: + type: boolean + description: Whether 'value' is binary data + ttl: + type: integer + description: Time-to-live in seconds (must be a positive + integer not exceeding MAX_TTL) + responses: + 200: + description: Value stored successfully + 400: + description: Invalid request body, or codec not allowed over the API + 404: + description: Extension not found + """ + extension_id = f"{publisher}.{name}" + extension = get_extension_or_404(extension_id) + if not extension: + return self.response_404("Extension not found") + + body = request.get_json(silent=True) or {} + if "value" not in body: + return self.response_400("Request body must contain 'value' field") + + codec = body.get("codec", DEFAULT_CODEC) + if not isinstance(codec, str) or codec not in SAFE_CODECS: + return self.response_400( + f"Codec '{codec}' is not allowed over the REST API." + ) + + is_binary = bool(body.get("isBinary", False)) + try: + value = _wire_value_for_request(body["value"], is_binary) + except (ValueError, TypeError): + return self.response_400( + "Value must be a valid base64 string when 'isBinary' is true." + ) + ttl, error = parse_ttl(body) + if error: + return self.response_400(error) + + shared = request.args.get("shared", "false").lower() == "true" + try: + ExtensionEphemeralDAO.set( + extension_id, key, value, ttl, codec=codec, shared=shared + ) + except (ExtensionEphemeralTTLInvalid, ExtensionEphemeralValueTooLarge) as ex: + return self.response_400(ex.message) Review Comment: Fixed — added a `KeyValueCodecEncodeException`/`TypeError`/`ValueError` catch here too, returning 400 instead of letting it 500, matching the persistent path's fix. ########## superset/extensions/storage/api.py: ########## @@ -0,0 +1,738 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +REST API for extension storage. + +Provides HTTP endpoints for frontend extensions to access server-side +ephemeral storage without direct backend code. + +All operations are user-scoped by default. Use `?shared=true` query param +to access shared state visible to all users. +""" + +from __future__ import annotations + +import base64 +from typing import Any + +from flask import g, request +from flask.wrappers import Response +from flask_appbuilder.api import BaseApi, expose, protect, safe + +from superset.extensions.storage.codecs import DEFAULT_CODEC, get_codec, SAFE_CODECS +from superset.extensions.storage.ephemeral_dao import ( + ExtensionEphemeralDAO, + ExtensionEphemeralTTLInvalid, + ExtensionEphemeralValueTooLarge, +) +from superset.extensions.storage.persistent_dao import ( + ExtensionStorageDAO, + ExtensionStorageKeyTooLong, + ExtensionStorageListPayloadTooLarge, + ExtensionStorageQuotaExceeded, + ExtensionStorageValueTooLarge, +) +from superset.extensions.storage.utils import get_extension_or_404, parse_ttl +from superset.key_value.exceptions import KeyValueCodecEncodeException +from superset.utils.decorators import transaction + + +def _decoded_result_for_wire(decoded: Any) -> tuple[Any, bool]: + """Convert a codec-decoded value into its JSON wire representation. + + JSON has no byte type, so a raw `bytes` value is base64-encoded to a + string for the response and flagged as such; every other value is + already JSON-representable as-is. Checked on the decoded value's + actual type, not the codec's name, so this keeps working for a codec + this module didn't define. + + :returns: (wire_value, is_binary) + """ + if isinstance(decoded, bytes): + return base64.b64encode(decoded).decode("ascii"), True + return decoded, False + + +def _wire_value_for_request(value: Any, is_binary: bool) -> Any: + """Convert a request body's JSON `value` into a codec's input type. + + `is_binary` is an explicit flag from the caller: JSON has no byte + type, so there is no way to tell, from the JSON `value` alone, + whether it is a base64 string that must be decoded to bytes before + being handed to the codec's `encode`, or a literal value to pass + through as-is. Only the caller knows which it sent. + + :raises ValueError: if `is_binary` is set and `value` is not a valid + base64 string. + """ + if is_binary: + return base64.b64decode(value, validate=True) + return value + + +class ExtensionStorageRestApi(BaseApi): + """REST API for extension ephemeral (Tier 2) and persistent (Tier 3) storage.""" + + allow_browser_login = True + route_base = "/api/v1/extensions" + + def response(self, status_code: int, **kwargs: Any) -> Response: + """Helper method to create JSON responses.""" + from flask import jsonify + + return jsonify(kwargs), status_code + + def response_404(self, message: str = "Not found") -> Response: + """Helper method to create 404 responses.""" + from flask import jsonify + + return jsonify({"message": message}), 404 + + def response_400(self, message: str) -> Response: + """Helper method to create 400 responses.""" + from flask import jsonify + + return jsonify({"message": message}), 400 + + @protect() + @safe + @expose("/<publisher>/<name>/storage/ephemeral/<key>", methods=("GET",)) + def get_ephemeral( + self, publisher: str, name: str, key: str, **kwargs: Any + ) -> Response: + """Get a value from ephemeral state. + --- + get: + summary: Get a value from ephemeral state + parameters: + - in: path + name: publisher + schema: + type: string + required: true + description: Extension publisher + - in: path + name: name + schema: + type: string + required: true + description: Extension name + - in: path + name: key + schema: + type: string + required: true + description: Storage key + - in: query + name: shared + schema: + type: boolean + required: false + description: If true, read from shared state visible to all users + responses: + 200: + description: Value retrieved successfully + content: + application/json: + schema: + type: object + properties: + result: + description: The stored value. When 'isBinary' is + true, this is a base64 string that must be + decoded to get the actual value. + codec: + type: string + description: Name of the codec 'result' was encoded + with, e.g. "json" (default) or "binary" + isBinary: + type: boolean + description: Whether the stored value is binary + data + 400: + description: Value was stored with a codec unavailable over the API + 404: + description: Extension not found + """ + extension_id = f"{publisher}.{name}" + extension = get_extension_or_404(extension_id) + if not extension: + return self.response_404("Extension not found") + + shared = request.args.get("shared", "false").lower() == "true" + raw = ExtensionEphemeralDAO.get_raw(extension_id, key, shared=shared) + if raw is None: + return self.response(200, result=None) + value, codec = raw + if codec not in SAFE_CODECS: + return self.response_400( + f"Value was stored with codec '{codec}', which cannot be " + "read over the REST API." + ) + + result, is_binary = _decoded_result_for_wire(get_codec(codec).decode(value)) + return self.response(200, result=result, codec=codec, isBinary=is_binary) + + @protect() + @safe + @expose("/<publisher>/<name>/storage/ephemeral/<key>", methods=("PUT",)) + def set_ephemeral( + self, publisher: str, name: str, key: str, **kwargs: Any + ) -> Response: + """Set a value in ephemeral state. + --- + put: + summary: Set a value in ephemeral state + parameters: + - in: path + name: publisher + schema: + type: string + required: true + description: Extension publisher + - in: path + name: name + schema: + type: string + required: true + description: Extension name + - in: path + name: key + schema: + type: string + required: true + description: Storage key + - in: query + name: shared + schema: + type: boolean + required: false + description: If true, store as shared state visible to all users + requestBody: + required: true + content: + application/json: + schema: + type: object + required: + - value + - ttl + properties: + value: + description: The value to store (must not exceed + MAX_VALUE_SIZE bytes once encoded with 'codec'). + When 'isBinary' is true, this must be a base64 + string, decoded before being handed to 'codec'. + codec: + type: string + description: Name of the codec used to encode 'value', + e.g. "json" (default). Must be one of the codecs + allowed over the REST API. + isBinary: + type: boolean + description: Whether 'value' is binary data + ttl: + type: integer + description: Time-to-live in seconds (must be a positive + integer not exceeding MAX_TTL) + responses: + 200: + description: Value stored successfully + 400: + description: Invalid request body, or codec not allowed over the API + 404: + description: Extension not found + """ + extension_id = f"{publisher}.{name}" + extension = get_extension_or_404(extension_id) + if not extension: + return self.response_404("Extension not found") + + body = request.get_json(silent=True) or {} + if "value" not in body: + return self.response_400("Request body must contain 'value' field") + + codec = body.get("codec", DEFAULT_CODEC) + if not isinstance(codec, str) or codec not in SAFE_CODECS: + return self.response_400( + f"Codec '{codec}' is not allowed over the REST API." + ) + + is_binary = bool(body.get("isBinary", False)) + try: + value = _wire_value_for_request(body["value"], is_binary) + except (ValueError, TypeError): + return self.response_400( + "Value must be a valid base64 string when 'isBinary' is true." + ) + ttl, error = parse_ttl(body) + if error: + return self.response_400(error) + + shared = request.args.get("shared", "false").lower() == "true" + try: + ExtensionEphemeralDAO.set( + extension_id, key, value, ttl, codec=codec, shared=shared + ) + except (ExtensionEphemeralTTLInvalid, ExtensionEphemeralValueTooLarge) as ex: + return self.response_400(ex.message) + + return self.response(200, message="Value stored successfully") + + @protect() + @safe + @expose("/<publisher>/<name>/storage/ephemeral/<key>", methods=("DELETE",)) + def delete_ephemeral( + self, publisher: str, name: str, key: str, **kwargs: Any + ) -> Response: + """Delete a value from ephemeral state. + --- + delete: + summary: Delete a value from ephemeral state + parameters: + - in: path + name: publisher + schema: + type: string + required: true + description: Extension publisher + - in: path + name: name + schema: + type: string + required: true + description: Extension name + - in: path + name: key + schema: + type: string + required: true + description: Storage key + - in: query + name: shared + schema: + type: boolean + required: false + description: If true, delete from shared state + responses: + 200: + description: Value deleted successfully + 404: + description: Extension not found + """ + extension_id = f"{publisher}.{name}" + extension = get_extension_or_404(extension_id) + if not extension: + return self.response_404("Extension not found") + + shared = request.args.get("shared", "false").lower() == "true" + ExtensionEphemeralDAO.delete(extension_id, key, shared=shared) + + return self.response(200, message="Value deleted successfully") + + @protect() + @safe + @expose("/<publisher>/<name>/storage/persistent", methods=("GET",)) + def list_persistent(self, publisher: str, name: str, **kwargs: Any) -> Response: + """List entries in persistent state. + --- + get: + summary: List entries in persistent state + parameters: + - in: path + name: publisher + schema: + type: string + required: true + description: Extension publisher + - in: path + name: name + schema: + type: string + required: true + description: Extension name + - in: query + name: shared + schema: + type: boolean + required: false + description: If true, list shared state visible to all users + - in: query + name: resource_type + schema: + type: string + required: false + description: Filter by resource type + - in: query + name: resource_uuid + schema: + type: string + required: false + description: Filter by resource UUID (requires resource_type) + - in: query + name: page + schema: + type: integer + required: false + description: Zero-indexed page number. Defaults to 0. + - in: query + name: page_size + schema: + type: integer + required: false + description: Number of entries per page. Defaults to 10. There + is no fixed ceiling, but a page whose combined value size + exceeds MAX_LIST_PAYLOAD_SIZE is rejected — reduce page_size + and retry if that happens. + responses: + 200: + description: Entries retrieved successfully + content: + application/json: + schema: + type: object + properties: + result: + type: array + items: + type: object + properties: + key: + type: string + value: + description: The stored value, or null if its + codec cannot be read over the REST API. + When 'isBinary' is true, this is a base64 + string that must be decoded to get the + actual value. + codec: + type: string + isBinary: + type: boolean + description: Whether the stored value is + binary data + count: + type: integer + description: Total number of entries matching the + given scope/filters, across all pages + 400: + description: The requested page's combined value size exceeds + MAX_LIST_PAYLOAD_SIZE + 404: + description: Extension not found + """ + extension_id = f"{publisher}.{name}" + extension = get_extension_or_404(extension_id) + if not extension: + return self.response_404("Extension not found") + + shared = request.args.get("shared", "false").lower() == "true" + user_fk = None if shared else g.user.id + resource_type = request.args.get("resource_type") + resource_uuid = request.args.get("resource_uuid") + try: + page = int(request.args.get("page", 0)) + page_size = int(request.args.get("page_size", 10)) + except (TypeError, ValueError): + return self.response_400("'page' and 'page_size' must be integers") + + try: + entries, count = ExtensionStorageDAO.list_entries( + extension_id, + user_fk=user_fk, + resource_type=resource_type, + resource_uuid=resource_uuid, + page=page, + page_size=page_size, + ) + except ExtensionStorageListPayloadTooLarge as ex: + return self.response(ex.status, message=ex.message) + + result = [] + for entry in entries: + value: Any = None + is_binary = False + if entry.codec in SAFE_CODECS and entry.value is not None: + decoded = get_codec(entry.codec).decode(entry.value) + value, is_binary = _decoded_result_for_wire(decoded) + result.append( + { + "key": entry.key, + "value": value, + "codec": entry.codec, + "isBinary": is_binary, + } + ) + + return self.response(200, result=result, count=count) + + @protect() + @safe + @expose("/<publisher>/<name>/storage/persistent/<key>", methods=("GET",)) + def get_persistent( + self, publisher: str, name: str, key: str, **kwargs: Any + ) -> Response: + """Get a value from persistent state. + --- + get: + summary: Get a value from persistent state + parameters: + - in: path + name: publisher + schema: + type: string + required: true + description: Extension publisher + - in: path + name: name + schema: + type: string + required: true + description: Extension name + - in: path + name: key + schema: + type: string + required: true + description: Storage key + - in: query + name: shared + schema: + type: boolean + required: false + description: If true, read from shared state visible to all users + responses: + 200: + description: Value retrieved successfully + content: + application/json: + schema: + type: object + properties: + result: + description: The stored value. When 'isBinary' is + true, this is a base64 string that must be + decoded to get the actual value. + codec: + type: string + description: Name of the codec 'result' was encoded + with, e.g. "json" (default) or "binary" + isBinary: + type: boolean + description: Whether the stored value is binary + data + 400: + description: Value was stored with a codec unavailable over the API + 404: + description: Extension not found + """ + extension_id = f"{publisher}.{name}" + extension = get_extension_or_404(extension_id) + if not extension: + return self.response_404("Extension not found") + + shared = request.args.get("shared", "false").lower() == "true" + user_fk = None if shared else g.user.id + entry = ExtensionStorageDAO.get(extension_id, key, user_fk=user_fk) + if entry is None: + return self.response(200, result=None) + if entry.codec not in SAFE_CODECS: + return self.response_400( + f"Value was stored with codec '{entry.codec}', which cannot be " + "read over the REST API." + ) + + decoded = ExtensionStorageDAO.get_decoded_value( + extension_id, key, user_fk=user_fk + ) Review Comment: Fixed — added `ExtensionStorageDAO.decode_entry()` to decode the already-fetched entry directly instead of re-querying, so the codec safety check and the decode always see the same row. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
