rusackas opened a new pull request, #43015:
URL: https://github.com/apache/superset/pull/43015
Follow-up to #41329.
### SUMMARY
#41329 replaced SQL Lab's native `prompt()` tab rename with a `Modal`, and
returns keyboard focus to the tab header after the modal closes. The author
explicitly deferred making the "..." (`MenuDotsDropdown`) trigger itself
focusable to a follow-up, so focus landed on the whole tab header wrapper
instead of the specific "Rename tab" menu trigger that opened the modal.
This makes `MenuDotsDropdown`'s trigger focusable (`tabIndex={0}`) and
forwards a ref to it, so `SqlEditorTabHeader` can return focus to that trigger
specifically, both after Save and after Cancel/close.
### TESTING INSTRUCTIONS
1. Open SQL Lab.
2. On a query tab, open the `⋮` menu and choose "Rename tab".
3. Save (or Cancel) the rename modal.
4. Focus returns to the `⋮` trigger for that tab, not the tab header as a
whole.
Covered by updated/added unit tests in `SqlEditorTabHeader.test.tsx` and
`Dropdown.test.tsx`.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
