rusackas commented on code in PR #43015:
URL: https://github.com/apache/superset/pull/43015#discussion_r3753808668
##########
superset-frontend/src/SqlLab/components/SqlEditorTabHeader/index.tsx:
##########
@@ -156,12 +156,9 @@ const SqlEditorTabHeader: FC<Props> = ({ queryEditor }) =>
{
return statusColors[state] || theme.colorIcon;
};
return (
- <TabTitleWrapper
- ref={tabHeaderRef}
- tabIndex={-1}
- data-test="sql-editor-tab-header"
- >
+ <TabTitleWrapper data-test="sql-editor-tab-header">
<MenuDotsDropdown
+ ref={dropdownTriggerRef}
trigger={['click']}
overlay={
Review Comment:
That's the intended change here, the whole point of this PR is making the
trigger focusable so focus can return to it after the rename modal closes.
`tabIndex={-1}` moved off `TabTitleWrapper`, not off `MenuDotsDropdown`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
