bito-code-review[bot] commented on code in PR #43015:
URL: https://github.com/apache/superset/pull/43015#discussion_r3753809594
##########
superset-frontend/src/SqlLab/components/SqlEditorTabHeader/index.tsx:
##########
@@ -156,12 +156,9 @@ const SqlEditorTabHeader: FC<Props> = ({ queryEditor }) =>
{
return statusColors[state] || theme.colorIcon;
};
return (
- <TabTitleWrapper
- ref={tabHeaderRef}
- tabIndex={-1}
- data-test="sql-editor-tab-header"
- >
+ <TabTitleWrapper data-test="sql-editor-tab-header">
<MenuDotsDropdown
+ ref={dropdownTriggerRef}
trigger={['click']}
overlay={
Review Comment:
<!-- Bito Reply -->
The change is intended to ensure the dropdown trigger is focusable, allowing
focus to return to it after the rename modal closes. Moving `tabIndex={-1}`
from the wrapper to the trigger itself is a valid approach to manage focus
behavior while maintaining the desired interaction flow.
**superset-frontend/src/SqlLab/components/SqlEditorTabHeader/index.tsx**
```
- <TabTitleWrapper
- ref={tabHeaderRef}
- tabIndex={-1}
- data-test="sql-editor-tab-header"
- >
+ <TabTitleWrapper data-test="sql-editor-tab-header">
<MenuDotsDropdown
+ ref={dropdownTriggerRef}
trigger={['click']}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
