bito-code-review[bot] commented on code in PR #43015:
URL: https://github.com/apache/superset/pull/43015#discussion_r3753035037
##########
superset-frontend/src/SqlLab/components/SqlEditorTabHeader/index.tsx:
##########
@@ -156,12 +156,9 @@ const SqlEditorTabHeader: FC<Props> = ({ queryEditor }) =>
{
return statusColors[state] || theme.colorIcon;
};
return (
- <TabTitleWrapper
- ref={tabHeaderRef}
- tabIndex={-1}
- data-test="sql-editor-tab-header"
- >
+ <TabTitleWrapper data-test="sql-editor-tab-header">
<MenuDotsDropdown
+ ref={dropdownTriggerRef}
trigger={['click']}
overlay={
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing tabIndex=-1 on dropdown</b></div>
<div id="fix">
MenuDotsDropdown lost `tabIndex={-1}` — without it, the dropdown trigger is
keyboard-focusable (tabIndex=0 default), changing interactive behavior from the
original `TabTitleWrapper`-wrapped setup. This may affect tab-navigation order
for power users.
</div>
</div>
<details>
<summary><b>Citations</b></summary>
<ul>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/beb8643/.cursor/rules/dev-standard.mdc#L37";>dev-standard.mdc:37</a>
</li>
</ul>
</details>
<small><i>Code Review Run #e1ee0c</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
