sadpandajoe commented on code in PR #43903: URL: https://github.com/apache/superset/pull/43903#discussion_r3939544813
########## docs/admin_docs/configuration/alerts-reports.mdx: ########## @@ -472,6 +472,48 @@ ALERT_REPORTS_ENABLE_LINK_REDIRECT = False The feature uses `WEBDRIVER_BASEURL_USER_FRIENDLY` (or `WEBDRIVER_BASEURL`) to determine which hosts are internal. +## Retry on Failure + +Reports (not alerts) can be configured to automatically retry when delivery +fails — for example a transient SMTP or Slack error — instead of moving +straight to an `Error` state. This is configured per report in the **Error +Handling** section of the report modal: + +- **Enable Retries** – turn on automatic retries for this report. +- **Maximum Retry Attempts** – how many times to retry before giving up (1–10, default 3). +- **Send Failed Reports** – still deliver the report to its recipients even after all retries fail (default off). Review Comment: This says the failed report is delivered, but exhaustion calls `send_final_failure_report()`, which sends an error notification rather than the screenshot/PDF/CSV/XLSX content. Could this describe it as a final failure notification so recipients do not expect the report output? ########## docs/admin_docs/configuration/alerts-reports.mdx: ########## @@ -472,6 +472,48 @@ ALERT_REPORTS_ENABLE_LINK_REDIRECT = False The feature uses `WEBDRIVER_BASEURL_USER_FRIENDLY` (or `WEBDRIVER_BASEURL`) to determine which hosts are internal. +## Retry on Failure + +Reports (not alerts) can be configured to automatically retry when delivery Review Comment: With the default configuration, this feature is disabled, so an operator following this section will not see the Error Handling controls or get any retries. Could this document the required `ALERT_REPORTS_RETRY` feature flag and its default? ########## docs/admin_docs/configuration/alerts-reports.mdx: ########## @@ -472,6 +472,48 @@ ALERT_REPORTS_ENABLE_LINK_REDIRECT = False The feature uses `WEBDRIVER_BASEURL_USER_FRIENDLY` (or `WEBDRIVER_BASEURL`) to determine which hosts are internal. +## Retry on Failure + +Reports (not alerts) can be configured to automatically retry when delivery +fails — for example a transient SMTP or Slack error — instead of moving +straight to an `Error` state. This is configured per report in the **Error +Handling** section of the report modal: + +- **Enable Retries** – turn on automatic retries for this report. +- **Maximum Retry Attempts** – how many times to retry before giving up (1–10, default 3). +- **Send Failed Reports** – still deliver the report to its recipients even after all retries fail (default off). +- **Failure Notifications** – choose whether **Owners** and/or **Report Recipients** get an email after each failed attempt. Review Comment: This overpromises the notification behavior: the initial failure schedules a retry without sending one, and configured report recipients keep their email/Slack/webhook channel rather than always getting email. Could this say notifications are sent after failed retry attempts and use the recipient's configured channel? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
