rusackas commented on code in PR #43903: URL: https://github.com/apache/superset/pull/43903#discussion_r3939708382
########## docs/admin_docs/configuration/alerts-reports.mdx: ########## @@ -472,6 +472,48 @@ ALERT_REPORTS_ENABLE_LINK_REDIRECT = False The feature uses `WEBDRIVER_BASEURL_USER_FRIENDLY` (or `WEBDRIVER_BASEURL`) to determine which hosts are internal. +## Retry on Failure + +Reports (not alerts) can be configured to automatically retry when delivery Review Comment: Good catch, added a note on the `ALERT_REPORTS_RETRY` flag (off by default) with a snippet to enable it. ########## docs/admin_docs/configuration/alerts-reports.mdx: ########## @@ -472,6 +472,48 @@ ALERT_REPORTS_ENABLE_LINK_REDIRECT = False The feature uses `WEBDRIVER_BASEURL_USER_FRIENDLY` (or `WEBDRIVER_BASEURL`) to determine which hosts are internal. +## Retry on Failure + +Reports (not alerts) can be configured to automatically retry when delivery +fails — for example a transient SMTP or Slack error — instead of moving +straight to an `Error` state. This is configured per report in the **Error +Handling** section of the report modal: + +- **Enable Retries** – turn on automatic retries for this report. +- **Maximum Retry Attempts** – how many times to retry before giving up (1–10, default 3). +- **Send Failed Reports** – still deliver the report to its recipients even after all retries fail (default off). Review Comment: Good catch, reworded that to call it a final failure notification rather than the report content itself. ########## docs/admin_docs/configuration/alerts-reports.mdx: ########## @@ -472,6 +472,48 @@ ALERT_REPORTS_ENABLE_LINK_REDIRECT = False The feature uses `WEBDRIVER_BASEURL_USER_FRIENDLY` (or `WEBDRIVER_BASEURL`) to determine which hosts are internal. +## Retry on Failure + +Reports (not alerts) can be configured to automatically retry when delivery +fails — for example a transient SMTP or Slack error — instead of moving +straight to an `Error` state. This is configured per report in the **Error +Handling** section of the report modal: + +- **Enable Retries** – turn on automatic retries for this report. +- **Maximum Retry Attempts** – how many times to retry before giving up (1–10, default 3). +- **Send Failed Reports** – still deliver the report to its recipients even after all retries fail (default off). +- **Failure Notifications** – choose whether **Owners** and/or **Report Recipients** get an email after each failed attempt. Review Comment: Fixed, now says it's sent after a failed retry attempt (not the first failure), and recipients get it on their own configured channel rather than always email. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
