sadpandajoe commented on code in PR #43903:
URL: https://github.com/apache/superset/pull/43903#discussion_r3947964869
##########
docs/admin_docs/configuration/alerts-reports.mdx:
##########
@@ -472,6 +472,65 @@ ALERT_REPORTS_ENABLE_LINK_REDIRECT = False
The feature uses `WEBDRIVER_BASEURL_USER_FRIENDLY` (or `WEBDRIVER_BASEURL`)
to determine which hosts are internal.
+## Retry on Failure
+
+This feature is gated behind the `ALERT_REPORTS_RETRY` feature flag, which is
+disabled by default:
+
+```python
+FEATURE_FLAGS = {
+ "ALERT_REPORTS_RETRY": True,
+}
+```
+
+With the flag enabled, reports (not alerts) can be configured to
+automatically retry when sending fails — this covers rendering/export
Review Comment:
This says rendering/export failures are retried, but `SoftTimeLimitExceeded`
and `ReportExecutionBudgetExceededError` are handled separately and move the
schedule straight to `Error` without calling the retry handler. A screenshot or
export that exceeds either limit will not retry even with this setting enabled.
Could this qualify the supported rendering/export failures (or make those
timeout paths participate in retries)?
##########
docs/admin_docs/configuration/alerts-reports.mdx:
##########
@@ -472,6 +472,65 @@ ALERT_REPORTS_ENABLE_LINK_REDIRECT = False
The feature uses `WEBDRIVER_BASEURL_USER_FRIENDLY` (or `WEBDRIVER_BASEURL`)
to determine which hosts are internal.
+## Retry on Failure
+
+This feature is gated behind the `ALERT_REPORTS_RETRY` feature flag, which is
+disabled by default:
+
+```python
+FEATURE_FLAGS = {
+ "ALERT_REPORTS_RETRY": True,
+}
+```
+
+With the flag enabled, reports (not alerts) can be configured to
+automatically retry when sending fails — this covers rendering/export
+failures (e.g. a chart screenshot or CSV export erroring out) as well as
+delivery failures such as a transient SMTP or Slack error — instead of
+moving straight to an `Error` state. This is configured per report in the
+**Error Handling** section of the report modal:
+
+- **Enable Retries** – turn on automatic retries for this report.
+- **Maximum Retry Attempts** – how many times to retry before giving up (1–10,
default 3).
+- **Send Failed Reports** – send a final failure notification to the report's
recipients once all retries fail (default off).
+- **Failure Notifications** – choose whether **Owners** and/or **Report
Recipients** get a notification after a failed retry attempt (not the initial
failure). Owners are notified by email; report recipients are notified on their
configured channel (email, Slack, etc).
Review Comment:
The report editor relation can contain users, roles, and groups, but owner
retry notifications are constructed only for user editors. A report owned
through a role or group can therefore have **Owners** enabled with no owner
notification sent. Could this distinguish user editors from role/group editors,
or make the notification behavior cover all supported owner types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
