rusackas commented on PR #38119: URL: https://github.com/apache/superset/pull/38119#issuecomment-5563898678
Looks like this cleaned up nicely since I last looked, CI's green across the board now and the getLabelPositionOptions/translation issue is sorted. Bito's flag was against the old constants.ts approach, which isn't part of this diff anymore, so that one's moot. Take it out of draft when you're ready and I'll give it a proper look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
