rusackas commented on code in PR #38119:
URL: https://github.com/apache/superset/pull/38119#discussion_r3946197638
##########
superset-frontend/plugins/plugin-chart-echarts/src/constants.ts:
##########
@@ -49,6 +49,32 @@ export const TIMESERIES_CONSTANTS = {
horizontalBarLabelRightPadding: 70,
};
+export const LABEL_POSITION: [LabelPositionEnum, string][] = [
+ [LabelPositionEnum.Top, 'Top'],
+ [LabelPositionEnum.Left, 'Left'],
+ [LabelPositionEnum.Right, 'Right'],
+ [LabelPositionEnum.Bottom, 'Bottom'],
+ [LabelPositionEnum.Inside, 'Inside'],
+ [LabelPositionEnum.InsideLeft, 'Inside left'],
+ [LabelPositionEnum.InsideRight, 'Inside right'],
+ [LabelPositionEnum.InsideTop, 'Inside top'],
+ [LabelPositionEnum.InsideBottom, 'Inside bottom'],
+ [LabelPositionEnum.InsideTopLeft, 'Inside top left'],
+ [LabelPositionEnum.InsideBottomLeft, 'Inside bottom left'],
+ [LabelPositionEnum.InsideTopRight, 'Inside top right'],
+ [LabelPositionEnum.InsideBottomRight, 'Inside bottom right'],
+];
+
+// Radar charts use polar coordinates and only support a limited set of label
positions
+// These are the positions that ECharts correctly renders for radar series
data items
+export const RADAR_LABEL_POSITION: [LabelPositionEnum, string][] = [
+ [LabelPositionEnum.Top, 'Top'],
+ [LabelPositionEnum.Left, 'Left'],
+ [LabelPositionEnum.Right, 'Right'],
+ [LabelPositionEnum.Bottom, 'Bottom'],
+ [LabelPositionEnum.Inside, 'Inside'],
Review Comment:
This comment is stale - it's anchored to an old commit (47a5d6ef) that no
longer exists after a rebase/force-push, and
`constants.ts`/`RADAR_LABEL_POSITION` aren't part of the current diff at all.
The actual labels live in `getLabelPositionOptions()` in `controlPanel.tsx`,
and they're already wrapped in `t()`. No change needed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
