bito-code-review[bot] commented on code in PR #38119:
URL: https://github.com/apache/superset/pull/38119#discussion_r3946198184
##########
superset-frontend/plugins/plugin-chart-echarts/src/constants.ts:
##########
@@ -49,6 +49,32 @@ export const TIMESERIES_CONSTANTS = {
horizontalBarLabelRightPadding: 70,
};
+export const LABEL_POSITION: [LabelPositionEnum, string][] = [
+ [LabelPositionEnum.Top, 'Top'],
+ [LabelPositionEnum.Left, 'Left'],
+ [LabelPositionEnum.Right, 'Right'],
+ [LabelPositionEnum.Bottom, 'Bottom'],
+ [LabelPositionEnum.Inside, 'Inside'],
+ [LabelPositionEnum.InsideLeft, 'Inside left'],
+ [LabelPositionEnum.InsideRight, 'Inside right'],
+ [LabelPositionEnum.InsideTop, 'Inside top'],
+ [LabelPositionEnum.InsideBottom, 'Inside bottom'],
+ [LabelPositionEnum.InsideTopLeft, 'Inside top left'],
+ [LabelPositionEnum.InsideBottomLeft, 'Inside bottom left'],
+ [LabelPositionEnum.InsideTopRight, 'Inside top right'],
+ [LabelPositionEnum.InsideBottomRight, 'Inside bottom right'],
+];
+
+// Radar charts use polar coordinates and only support a limited set of label
positions
+// These are the positions that ECharts correctly renders for radar series
data items
+export const RADAR_LABEL_POSITION: [LabelPositionEnum, string][] = [
+ [LabelPositionEnum.Top, 'Top'],
+ [LabelPositionEnum.Left, 'Left'],
+ [LabelPositionEnum.Right, 'Right'],
+ [LabelPositionEnum.Bottom, 'Bottom'],
+ [LabelPositionEnum.Inside, 'Inside'],
Review Comment:
<!-- Bito Reply -->
The suggestion to wrap UI labels in `t()` is a standard internationalization
practice. However, if the code in question is no longer part of the current
diff or if the labels are already handled elsewhere, the suggestion is not
applicable. You can safely ignore or resolve this comment as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
