Ujjwaljain16 commented on PR #44069: URL: https://github.com/apache/superset/pull/44069#issuecomment-5601190481
heyyy i was tracing this through the other filter types and noticed that `filter_range` is also allowed to participate in cascading dependencies. would it be worth handling the cleared value differently for Range filters? it looks like `RangeFilterPlugin` expects an empty value in the form of `[null, null]`, whereas this change sets the child value to `null`. From the plugin's state-sync logic, it seems like a bare `null` may not update the local range input, so the UI could potentially keep showing the previous range even though the underlying `extraFormData` has been cleared i may be missing something here but could we add a small test for a range filter as the dependent child to make sure it gets cleared visually as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
