Ujjwaljain16 commented on PR #44069: URL: https://github.com/apache/superset/pull/44069#issuecomment-5601203752
also one small thing i noticed while going through the integration test: the current assertions verify that the child's `dataMask` is cleared when Apply is clicked, but i don't think they verify that the child filter's UI selection is actually cleared since`cascadeClearTrigger` is what appears to handle the visual/plugin state, would it make sense to also assert that the previously selected `New York` value is no longer shown in the City filter? that way the test would cover both sides of the fix the staged state and the actual filter UI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
