bito-code-review[bot] commented on PR #44105: URL: https://github.com/apache/superset/pull/44105#issuecomment-5612518469
<!-- Bito Reply --> The flagged issue is correct: the test case for cached results only verifies the `is_cached` flag and does not validate that the `from_dttm` and `to_dttm` fields are correctly reconstructed or serialized from the cache. To resolve this, the test should be updated to mock a cache entry containing specific time bounds and assert that these values are correctly returned in the `QueryDatasetResponse` when `is_cached` is true. I have not implemented the fix as the test file is not present in the provided PR context. Please provide the test file content if you would like me to implement the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
