codeant-ai-for-open-source[bot] commented on code in PR #44105:
URL: https://github.com/apache/superset/pull/44105#discussion_r3975256547
##########
tests/unit_tests/mcp_service/dataset/tool/test_query_dataset.py:
##########
@@ -1406,3 +1408,75 @@ def capture_create(**kwargs):
assert since is not None
assert until is not None
assert since < until
+
+
[email protected](
+ ("expression", "expected_start", "expected_end"),
+ [
+ ("Last month", "2026-06-17T00:00:00", "2026-07-17T00:00:00"),
+ ("Last year", "2025-07-17T00:00:00", "2026-07-17T00:00:00"),
+ ("previous calendar month", "2026-06-01T00:00:00",
"2026-07-01T00:00:00"),
+ ("Current year", "2026-01-01T00:00:00", "2027-01-01T00:00:00"),
+ ("2025-06-01 : 2025-07-01", "2025-06-01T00:00:00",
"2025-07-01T00:00:00"),
+ ("No filter", None, None),
+ ],
+)
[email protected]("use_filter", [False, True])
[email protected]("result_kind", ["fresh", "cached", "empty"])
[email protected]
+async def test_query_dataset_returns_engine_time_bounds(
+ mcp_server: FastMCP,
+ expression: str,
+ expected_start: str | None,
+ expected_end: str | None,
+ use_filter: bool,
+ result_kind: str,
+) -> None:
+ """Resolve MCP inputs with the real factory and serialize execution
bounds."""
+ from flask import current_app
+ from freezegun import freeze_time
+
+ from superset.common.chart_data import ChartDataResultType
+ from superset.common.query_object_factory import QueryObjectFactory
+
+ dataset = _make_dataset(main_dttm_col="order_date")
+
+ def execute(
+ datasource_id: int, datasource_type: str, query_dict: dict[str, Any],
**_: Any
+ ) -> dict[str, Any]:
+ """Use production date resolution in place of database execution."""
+ factory = QueryObjectFactory(current_app.config, MagicMock())
+ with freeze_time("2026-07-17 12:34:56"):
+ query = factory.create(
+ parent_result_type=ChartDataResultType.FULL,
+ **query_dict,
+ )
+ payload = _mock_command_result()
+ result = payload["queries"][0]
+ result.update(from_dttm=query.from_dttm, to_dttm=query.to_dttm)
+ result["is_cached"] = result_kind == "cached"
Review Comment:
**Suggestion:** The cached case only flips `is_cached`; it never exercises
cache serialization or reconstruction, so missing or altered cached time bounds
can pass this test. [incomplete implementation]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e89814cf867843e0b6786cad93ca7e0b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e89814cf867843e0b6786cad93ca7e0b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/mcp_service/dataset/tool/test_query_dataset.py
**Line:** 1456:1457
**Comment:**
*Incomplete Implementation: The cached case only flips `is_cached`; it
never exercises cache serialization or reconstruction, so missing or altered
cached time bounds can pass this test.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44105&comment_hash=0a9c9204044742309fee4b785b589cf5517472daaa45709310dce95a005db4a7&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44105&comment_hash=0a9c9204044742309fee4b785b589cf5517472daaa45709310dce95a005db4a7&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
