aminghadersohi commented on PR #44105: URL: https://github.com/apache/superset/pull/44105#issuecomment-5612784147
Addressed the review comments in d4b228a7e0. The cache-serialization suggestion is covered by a real cache write/read regression test across a frozen-clock rollover, for both populated and empty results; details are in the review-thread reply. The external one-sided-range report does not reproduce through MCP validation, so I added entry-point regression tests and clarified the documentation rather than changing query behavior. @gabotorresruiz Both bound descriptions retain the explicit rollover caveat. They point to `cache_status.cache_hit`: the new empty-result cache test confirms that `performance.cache_status` is `no_data` even on a cache hit. Validation: **134 targeted tool tests passed** with the local `superset-core/src` source path configured. `uvx pre-commit run --files <all branch-changed files>` passed, including mypy and pylint. CI had no failed checks before this push; remaining jobs were running. The PR remains ready for review, not draft. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
