aminghadersohi commented on PR #44105: URL: https://github.com/apache/superset/pull/44105#issuecomment-5612565860
@gabotorresruiz Thanks for the careful verification. Updated both `from_dttm` and `to_dttm` descriptions in `QueryDatasetResponse` and `GetTableResponse` in 16ecbfcac0 with: "On cache hits, these are current-request bounds; cached rows can reflect an earlier relative range. Check performance.cache_status." This explicitly covers the rollover case you verified: `QueryObject.cache_key` retains the relative `time_range` and removes `from_dttm`/`to_dttm`, so the resolved bounds do not establish the range of the cached rows. Description-only change; no behavior changes. Validation: `uvx pre-commit run --files <all branch-changed files>` passed, including mypy and pylint. Targeted unit tests were blocked during collection by local test-environment initialization. Before this push, CI had no failed checks, with 15 still pending/running. Left the PR ready for review (not draft). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
