EnxDev commented on code in PR #44391:
URL: https://github.com/apache/superset/pull/44391#discussion_r4047008218
##########
superset/utils/core.py:
##########
@@ -2220,12 +2220,33 @@ def apply_max_row_limit(
return max_limit
+def write_zip_entry(bundle: ZipFile, filename: str, contents: bytes) -> None:
Review Comment:
Could we also reuse this helper in `export_dashboards` and
`export_datasources` in `superset/cli/importexport.py`? Both still write
entries with `bundle.open(..., "w")` (lines 108 and 141), so CLI exports keep
the 1980 timestamp while the equivalent API exports get the export time. This
could be a follow-up if you'd like to keep this PR focused on downloads; using
the helper there would make the behavior consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
