codeant-ai-for-open-source[bot] commented on code in PR #44391:
URL: https://github.com/apache/superset/pull/44391#discussion_r4053838253
##########
superset/utils/core.py:
##########
@@ -2220,12 +2220,31 @@ def apply_max_row_limit(
return max_limit
+def write_zip_entry(bundle: ZipFile, filename: str, contents: bytes) -> None:
+ """Add a file to an open ZIP bundle, stamped with the current local time.
+
+ ``ZipFile.open(name, "w")`` falls back to the 1980-01-01 DOS epoch, which
+ extractors surface as a bogus (Windows Explorer) or empty (7-Zip)
+ modification date on every extracted file. Passing an explicit ``ZipInfo``
+ gives the entry the time the export was generated instead.
+ """
+ info = ZipInfo(filename=filename, date_time=datetime.now().timetuple()[:6])
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag potential ZIP timestamp failures from system clocks before
1980 when the code preserves existing timestamp behavior and does not introduce
a new failure mode.
**Applied to:**
- `superset/utils/core.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
