DeVaNsHk72 commented on code in PR #44391:
URL: https://github.com/apache/superset/pull/44391#discussion_r4049225318
##########
superset/utils/core.py:
##########
@@ -2220,12 +2220,33 @@ def apply_max_row_limit(
return max_limit
+def write_zip_entry(bundle: ZipFile, filename: str, contents: bytes) -> None:
Review Comment:
Good catch, thanks — I've folded it in rather than leaving it as a
follow-up, since it's the same 4-line change and having the CLI and API
disagree on timestamps felt like the odd outcome.
Done in 1b7c509: both `export_dashboards` and `export_datasources` now go
through `write_zip_entry`. That was the last of the old `bundle.open(..., "w")`
writes — I grepped the tree and nothing else is left.
Checked it end to end with the real command rather than just the tests:
```
$ superset export-datasources
dataset_export_20260918T230312/metadata.yaml (2026, 9, 18, 23, 3, 12)
mode=0o600
dataset_export_20260918T230312/datasets/... (2026, 9, 18, 23, 3, 12)
mode=0o600
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
