bito-code-review[bot] commented on PR #44391: URL: https://github.com/apache/superset/pull/44391#issuecomment-5730468208
<!-- Bito Reply --> Yes, reusing the `write_zip_entry` helper in `export_dashboards` and `export_datasources` within `superset/cli/importexport.py` is a recommended approach. This would ensure consistent behavior across both CLI and API exports by correctly stamping entries with the current time instead of the 1980 DOS epoch. Since this PR already introduces `write_zip_entry` in `superset/utils/core.py` and applies it to various API export endpoints, extending it to the CLI commands is a logical follow-up to maintain uniformity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
