fitzee commented on code in PR #44465:
URL: https://github.com/apache/superset/pull/44465#discussion_r4061065133
##########
superset/commands/report/execute.py:
##########
@@ -808,12 +810,16 @@ def _get_screenshots(self) -> list[bytes]:
imge = screenshot.get_screenshot(
user=user,
log_context=self._log_context,
- report_execution_context=self._report_execution_context,
+ report_execution_context=(
+ self._report_execution_context if for_delivery else
None
+ ),
)
if imge is None:
raise ReportScheduleScreenshotFailedError(
"Screenshot failed; aborting to avoid sending a
partial report"
)
+ if for_delivery:
+ self._validate_screenshot(imge)
Review Comment:
Fixed in 289ec89ea800d8a97f92820a7b3b54e22264aa15. Tiled captures preserve
their region-level validation through the final gate, while the combined bytes
must still decode successfully before approval. Tests cover sparse content
surrounded by empty tiles, empty/error-only dashboards, and corrupt combined
output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
