fitzee commented on code in PR #44465:
URL: https://github.com/apache/superset/pull/44465#discussion_r4061065758
##########
superset/commands/report/execute.py:
##########
@@ -808,12 +810,16 @@ def _get_screenshots(self) -> list[bytes]:
imge = screenshot.get_screenshot(
user=user,
log_context=self._log_context,
- report_execution_context=self._report_execution_context,
+ report_execution_context=(
+ self._report_execution_context if for_delivery else
None
Review Comment:
Fixed in 289ec89ea800d8a97f92820a7b3b54e22264aa15. Bootstrap captures retain
the shared execution deadline and reserves, with delivery validation disabled
separately. Tests cover CSV/XLSX/TEXT bootstrap and verify that readiness
retains the 690-second budget rather than falling back to 60 seconds.
##########
superset/utils/webdriver.py:
##########
@@ -721,25 +755,50 @@ def _wait_for_charts_ready( # noqa: C901
)
return
chart_holder_states = page.evaluate(FIND_CHART_HOLDER_STATES_JS)
- mounted_holders = len(chart_holder_states)
- ready_holders = sum(
- holder.get("state") in ready_states for holder in
chart_holder_states
+ diagnostics =
ChartHolderDiagnostics.from_holder_states(chart_holder_states)
Review Comment:
Fixed in 289ec89ea800d8a97f92820a7b3b54e22264aa15. Standard report
diagnostics scan every dashboard holder, including off-screen errors. Tiled
diagnostics remain viewport-scoped. Tests execute both JavaScript scans and
verify the standard path emits the terminal-error warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
