fitzee commented on PR #44465: URL: https://github.com/apache/superset/pull/44465#issuecomment-5768230031
Reviewed the latest Bito suggestions. Clarified readiness versus delivery, consolidated the heuristic caveat, explained the logo threshold distinction, and added the requested diagnostics-test docstrings in f4ef4cc50fd26c02e4963240c523e285019a4541. All 141 selected tests and PR pre-commit checks pass. The tiled logging observation is a real scope limitation, not a new delivery check: final counts aggregate terminal states observed across captured viewports, rather than every holder ever present in the DOM. Documented that limitation and the need to compare per-tile diagnostics with expected holder counts. No claim that never-visible holders were captured. Leaving the small semantic-success helper extraction, threshold constant extraction, inferable local annotations, and broad test-style cleanup out of this fix. The nested blank check intentionally distinguishes blank pixels with no rendered chart content; the shared validator still checks those bytes before approval. No runtime behaviour changed in this cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
