fitzee commented on code in PR #44465:
URL: https://github.com/apache/superset/pull/44465#discussion_r4061669597
##########
superset/utils/webdriver.py:
##########
@@ -361,6 +372,11 @@ def _get_validated_screenshot(
context_suffix,
)
if not is_blank:
+ if blankness.is_blank:
+ report_execution_context.approve_artifact(
Review Comment:
Fixed in 43cde6c572670aadeafa21ae967a8a60c954dce2. Standard
empty/error-state captures use the shared validator before recording approval,
preserving the content-state exception without bypassing file-integrity checks.
Regression tests corrupt an IDAT checksum for both chart and dashboard captures
and verify rejection, no approval, and rejection again at the final gate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
