bito-code-review[bot] commented on code in PR #44465:
URL: https://github.com/apache/superset/pull/44465#discussion_r4066847724
##########
tests/unit_tests/utils/test_report_execution.py:
##########
@@ -136,6 +180,23 @@ def test_capture_rejection_is_sticky_for_the_execution()
-> None:
)
+def test_artifact_approval_is_namespaced_by_kind() -> None:
+ context = ReportExecutionContext(
+ execution_id=UUID("084e7ee6-5557-4ecd-9632-b7f39c9ec524"),
+ report_schedule_id=7,
+ deadline=ReportExecutionDeadline(total_seconds=900),
+ )
+ artifact = b"same exact bytes"
Review Comment:
<!-- Bito Reply -->
The decision to omit the explicit type annotation is reasonable. Since the
bytes literal has an unambiguous inferred type and the code passes existing
repository checks, adding an explicit annotation would not provide additional
clarity or correctness in this specific test context.
##########
tests/unit_tests/utils/test_screenshot_utils.py:
##########
@@ -90,6 +96,45 @@ def
test_stable_readiness_skips_when_budget_below_polling_margin() -> None:
page.wait_for_function.assert_not_called()
+def test_holder_diagnostics_include_offscreen_errors_for_full_capture() ->
None:
Review Comment:
<!-- Bito Reply -->
The suggestion to add a docstring to the new test function is appropriate.
It improves code maintainability by documenting the specific diagnostic
scenario being tested, as required by the project's documentation standards.
**tests/unit_tests/utils/test_screenshot_utils.py**
```
def test_holder_diagnostics_include_offscreen_errors_for_full_capture() ->
None:
"""Verifies that full-capture diagnostics report off-screen errors
correctly."""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
