rusackas commented on code in PR #43566:
URL: https://github.com/apache/superset/pull/43566#discussion_r4068661582
##########
superset/db_engine_specs/aurora.py:
##########
@@ -36,6 +37,26 @@ class AuroraMySQLDataAPI(MySQLEngineSpec):
"region_name={region_name}"
)
+ metadata = {
+ "description": (
+ "Amazon Aurora MySQL accessed via the AWS Data API, allowing "
+ "database queries over HTTP without managing persistent
connections."
+ ),
+ "logo": "aws-aurora.jpg",
+ "homepage_url": "https://aws.amazon.com/rds/aurora/";,
+ "categories": [
+ DatabaseCategory.CLOUD,
+ DatabaseCategory.POPULAR,
+ ],
Review Comment:
Confirmed fixed in `55a0fe3`, the categories are `CLOUD_AWS` /
`TRADITIONAL_RDBMS` / `HOSTED_OPEN_SOURCE` now. Resolving.
##########
superset/db_engine_specs/aurora.py:
##########
@@ -36,6 +37,26 @@ class AuroraMySQLDataAPI(MySQLEngineSpec):
"region_name={region_name}"
)
+ metadata = {
+ "description": (
+ "Amazon Aurora MySQL accessed via the AWS Data API, allowing "
+ "database queries over HTTP without managing persistent
connections."
+ ),
+ "logo": "aws-aurora.jpg",
+ "homepage_url": "https://aws.amazon.com/rds/aurora/";,
+ "categories": [
+ DatabaseCategory.CLOUD,
+ DatabaseCategory.POPULAR,
+ ],
+ "pypi_packages": ["auroradataapi"],
Review Comment:
Yep, `55a0fe3` switched this to `sqlalchemy-aurora-data-api`. Resolving.
##########
superset/db_engine_specs/databend.py:
##########
@@ -162,8 +162,24 @@ class DatabendEngineSpec(DatabendBaseEngineSpec):
_show_functions_column = "name"
supports_file_upload = False
- # Note: Primary metadata is in DatabendConnectEngineSpec which provides
- # the native connection UI. This spec exists for backwards compatibility.
+ metadata = {
+ "description": (
+ "Databend is an open-source cloud-native data warehouse built in
Rust "
+ "(legacy databend-sqlalchemy connector)."
+ ),
+ "logo": "databend.png",
+ "homepage_url": "https://www.databend.com/";,
+ "categories": [
+ DatabaseCategory.CLOUD_DATA_WAREHOUSES,
+ DatabaseCategory.ANALYTICAL_DATABASES,
+ DatabaseCategory.PROPRIETARY,
+ ],
Review Comment:
Already fixed in `55a0fe3`, Databend is tagged `OPEN_SOURCE` now. Resolving.
##########
superset/db_engine_specs/databricks.py:
##########
@@ -230,9 +230,22 @@ class DatabricksHiveEngineSpec(HiveEngineSpec):
drivers = {"pyhive": "Hive driver for Interactive Cluster"}
default_driver = "pyhive"
- # Note: Primary metadata is in DatabricksPythonConnectorEngineSpec which
- # consolidates all Databricks connection methods. This spec exists for
- # backwards compatibility with Interactive Cluster connections.
+ metadata = {
+ "description": (
+ "Databricks Interactive Cluster connectivity via the PyHive
connector."
+ ),
+ "logo": "databricks.png",
+ "homepage_url": "https://www.databricks.com/";,
+ "categories": [
+ DatabaseCategory.CLOUD_DATA_WAREHOUSES,
+ DatabaseCategory.ANALYTICAL_DATABASES,
+ ],
+ "pypi_packages": ["pyhive"],
+ "connection_string": (
+ "databricks+pyhive://token:{access_token}@{host}:{port}/{database}"
+ ),
+ "default_port": 443,
+ }
Review Comment:
Covered in `55a0fe3`... the legacy connection string carries
`?http_path={http_path}` now and it is documented under `parameters`. Resolving.
##########
superset/db_engine_specs/databricks.py:
##########
@@ -456,9 +480,22 @@ class
DatabricksNativeEngineSpec(DatabricksDynamicBaseEngineSpec):
"databricks+connector://token:{access_token}@{host}:{port}/{database_name}"
)
- # Note: Primary metadata is in DatabricksPythonConnectorEngineSpec which
- # consolidates all Databricks connection methods. This spec exists for
- # backwards compatibility with legacy databricks-dbapi connections.
+ metadata = {
+ "description": (
+ "Legacy Databricks connector using the databricks-dbapi driver."
+ ),
+ "logo": "databricks.png",
+ "homepage_url": "https://www.databricks.com/";,
+ "categories": [
+ DatabaseCategory.CLOUD_DATA_WAREHOUSES,
+ DatabaseCategory.ANALYTICAL_DATABASES,
+ ],
+ "pypi_packages": ["databricks-dbapi"],
Review Comment:
Fixed in `55a0fe3`, the package is `databricks-dbapi[sqlalchemy]` now.
Resolving.
##########
superset/db_engine_specs/elasticsearch.py:
##########
@@ -204,6 +204,22 @@ class OpenDistroEngineSpec(BaseEngineSpec): # pylint:
disable=abstract-method
engine = "odelasticsearch"
engine_name = "OpenSearch (OpenDistro)"
+ metadata = {
+ "description": (
+ "OpenSearch (OpenDistro) is a community-driven, open-source search
"
+ "and analytics suite derived from Elasticsearch."
+ ),
+ "logo": "elasticsearch.png",
+ "homepage_url": "https://opensearch.org/";,
Review Comment:
There is no OpenSearch logo asset in the repo, and the existing Amazon
OpenSearch Service entry on `master` uses `elasticsearch.png` too, so this
matches what we have. A dedicated logo could be a follow-up, but I would not
block on it. Resolving.
##########
superset/db_engine_specs/ibmi.py:
##########
@@ -28,6 +30,22 @@ class IBMiEngineSpec(Db2EngineSpec):
engine_name = "IBM Db2 for i"
max_column_name_length = 128
+ metadata = {
+ "description": (
+ "IBM Db2 for i is an integrated relational database management "
+ "system optimized for IBM i."
+ ),
+ "logo": "ibm-db2.svg",
+ "homepage_url": "https://www.ibm.com/products/db2";,
+ "categories": [
+ DatabaseCategory.TRADITIONAL_RDBMS,
+ DatabaseCategory.ENTERPRISE,
+ ],
+ "pypi_packages": ["sqlalchemy-ibmi"],
+ "connection_string":
"ibmi://{user}:{password}@{host}:{port}/{database}",
+ "default_port": 50000,
Review Comment:
Fixed in `55a0fe3`, the template uses `{username}` now. Resolving.
##########
superset/db_engine_specs/kusto.py:
##########
@@ -174,6 +174,26 @@ class KustoKqlEngineSpec(BaseEngineSpec): # pylint:
disable=abstract-method
allows_sql_comments = False
run_multiple_statements_as_one = True
+ metadata = {
+ "description": (
+ "Azure Data Explorer (Kusto) using native Kusto Query Language
(KQL) "
+ "for high-performance log and telemetry analytics."
+ ),
+ "logo": "kusto.png",
+ "homepage_url":
"https://azure.microsoft.com/en-us/products/data-explorer/";,
+ "categories": [
+ DatabaseCategory.CLOUD_AZURE,
+ DatabaseCategory.ANALYTICAL_DATABASES,
+ DatabaseCategory.PROPRIETARY,
+ ],
+ "pypi_packages": ["sqlalchemy-kusto"],
+ "connection_string": (
+ "kustokql+https://{cluster}.kusto.windows.net/{database}";
+ "?msi=False&azure_ad_client_id={client_id}"
+ "&azure_ad_client_secret={client_secret}"
+ ),
+ }
Review Comment:
Fixed in `55a0fe3`, the KQL string has `azure_ad_tenant_id={tenant_id}` now
and `tenant_id` is documented. Resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
