rusackas commented on code in PR #43566:
URL: https://github.com/apache/superset/pull/43566#discussion_r4074719083
##########
superset/db_engine_specs/ibmi.py:
##########
@@ -28,6 +30,29 @@ class IBMiEngineSpec(Db2EngineSpec):
engine_name = "IBM Db2 for i"
max_column_name_length = 128
+ metadata = {
+ "description": (
+ "IBM Db2 for i is an integrated relational database management "
+ "system optimized for IBM i."
+ ),
+ "logo": "ibm-db2.svg",
+ "homepage_url": "https://www.ibm.com/products/db2-for-i";,
+ "categories": [
+ DatabaseCategory.TRADITIONAL_RDBMS,
+ DatabaseCategory.PROPRIETARY,
+ ],
+ "pypi_packages": ["sqlalchemy-ibmi"],
+ "connection_string": "ibmi://{username}:{password}@{host}/{database}",
+ "parameters": {
+ "username": "IBM i user profile",
+ "password": "User password",
+ "host": "Hostname or IP address",
+ "database": "Database name",
+ },
+ "docs_url": "https://github.com/IBM/sqlalchemy-ibmi";,
+ "sqlalchemy_docs_url": "https://github.com/IBM/sqlalchemy-ibmi";,
+ }
Review Comment:
Same ast-static-analysis constraint as the other duplication threads on this
PR, the two blocks have to stay literal for `lint_metadata.py`, so
consolidating them isn't really on the table. But the underlying observation is
real: `database` reads "Database name" here and "Library/schema name" in
`db2.py`'s `compatible_databases` entry for the same connector. The Db2 one has
the right AS/400 terminology. Fix suggested below. Resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
