rusackas commented on code in PR #43566:
URL: https://github.com/apache/superset/pull/43566#discussion_r4074721155
##########
superset/db_engine_specs/ibmi.py:
##########
@@ -28,6 +30,29 @@ class IBMiEngineSpec(Db2EngineSpec):
engine_name = "IBM Db2 for i"
max_column_name_length = 128
+ metadata = {
+ "description": (
+ "IBM Db2 for i is an integrated relational database management "
+ "system optimized for IBM i."
+ ),
+ "logo": "ibm-db2.svg",
+ "homepage_url": "https://www.ibm.com/products/db2-for-i";,
+ "categories": [
+ DatabaseCategory.TRADITIONAL_RDBMS,
+ DatabaseCategory.PROPRIETARY,
+ ],
+ "pypi_packages": ["sqlalchemy-ibmi"],
+ "connection_string": "ibmi://{username}:{password}@{host}/{database}",
+ "parameters": {
+ "username": "IBM i user profile",
+ "password": "User password",
+ "host": "Hostname or IP address",
+ "database": "Database name",
Review Comment:
```suggestion
"database": "Library/schema name",
```
##########
superset/db_engine_specs/elasticsearch.py:
##########
@@ -324,6 +324,27 @@ class OpenDistroEngineSpec(BaseEngineSpec): # pylint:
disable=abstract-method
engine = "odelasticsearch"
engine_name = "OpenSearch (OpenDistro)"
+ metadata = {
Review Comment:
Bito wanted a `drivers` field here to match `ElasticSearchEngineSpec`. It's
in `OPTIONAL_FIELDS` in `lint_metadata.py`, not required, and this spec's
already at 100% on required fields. Fine to leave for a follow-up if someone
wants to flesh it out.
##########
superset/db_engine_specs/kusto.py:
##########
@@ -223,6 +223,34 @@ class KustoKqlEngineSpec(BaseEngineSpec): # pylint:
disable=abstract-method
allows_sql_comments = False
run_multiple_statements_as_one = True
+ metadata = {
Review Comment:
Bito wanted a `known_incompatibilities` entry mirroring
`KustoSqlEngineSpec`. That's not even in the `lint_metadata.py` schema
(required, recommended, or optional), so there's nothing to satisfy here. Not a
blocker.
##########
superset/db_engine_specs/aurora.py:
##########
@@ -36,6 +37,27 @@ class AuroraMySQLDataAPI(MySQLEngineSpec):
"region_name={region_name}"
)
+ metadata = {
Review Comment:
Bito also wanted dedicated tests asserting on these metadata dicts. Checked
the convention first, `lint_metadata.py --strict` in pre-commit is what
actually validates this content across the repo, and only one existing spec
test (`test_postgres.py`) even touches `.metadata[...]`. Not a real gap here.
##########
superset/db_engine_specs/aurora.py:
##########
@@ -68,6 +111,24 @@ class AuroraMySQLEngineSpec(MySQLEngineSpec):
engine_name = "Aurora MySQL"
default_driver = "mysqldb"
+ metadata = {
+ "description": (
+ "Amazon Aurora MySQL is a relational database engine that combines
"
+ "high-end commercial database speed with the simplicity of "
+ "open-source MySQL."
+ ),
+ "logo": "aws-aurora.jpg",
+ "homepage_url": "https://aws.amazon.com/rds/aurora/";,
+ "categories": [
+ DatabaseCategory.CLOUD_AWS,
+ DatabaseCategory.TRADITIONAL_RDBMS,
+ DatabaseCategory.HOSTED_OPEN_SOURCE,
Review Comment:
Bito flagged this as inconsistent with `MySQLEngineSpec`'s `OPEN_SOURCE`,
reasoning only the Data API variants qualify for `HOSTED_OPEN_SOURCE`. I don't
buy that read, Aurora is AWS-hosted regardless of whether you connect via the
Data API or the wire protocol, so `HOSTED_OPEN_SOURCE` across all four Aurora
specs is the consistent story, not a mismatch. Leaving as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
