bito-code-review[bot] commented on code in PR #43566:
URL: https://github.com/apache/superset/pull/43566#discussion_r4074720732
##########
superset/db_engine_specs/ibmi.py:
##########
@@ -28,6 +30,29 @@ class IBMiEngineSpec(Db2EngineSpec):
engine_name = "IBM Db2 for i"
max_column_name_length = 128
+ metadata = {
+ "description": (
+ "IBM Db2 for i is an integrated relational database management "
+ "system optimized for IBM i."
+ ),
+ "logo": "ibm-db2.svg",
+ "homepage_url": "https://www.ibm.com/products/db2-for-i";,
+ "categories": [
+ DatabaseCategory.TRADITIONAL_RDBMS,
+ DatabaseCategory.PROPRIETARY,
+ ],
+ "pypi_packages": ["sqlalchemy-ibmi"],
+ "connection_string": "ibmi://{username}:{password}@{host}/{database}",
+ "parameters": {
+ "username": "IBM i user profile",
+ "password": "User password",
+ "host": "Hostname or IP address",
+ "database": "Database name",
+ },
+ "docs_url": "https://github.com/IBM/sqlalchemy-ibmi";,
+ "sqlalchemy_docs_url": "https://github.com/IBM/sqlalchemy-ibmi";,
+ }
Review Comment:
<!-- Bito Reply -->
The observation regarding the terminology mismatch for the database
parameter is correct. Since the block must remain literal for linting purposes,
the current implementation is acceptable as a necessary constraint. No further
action is required for this thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
