sha174n commented on PR #44080: URL: https://github.com/apache/superset/pull/44080#issuecomment-5772735256
@rusackas no change to either rule you raised, but the guard you asked about moved in 0da560b: the datasource-type and still-virtual checks now live inside `_repoints_table` instead of in the caller's `and` chain, so the predicate is self-contained rather than relying on a precondition the caller has to enforce. The type check still short-circuits ahead of `table_name`/`is_virtual`, and `test_save_of_non_dataset_datasource_skips_table_check` still covers it. Same commit routes the last two save tests through the shared helper. 24 tests green, pre-commit clean. Unrelated to this diff: the current red CI is `messages.pot` drift inherited from master (alert-retry and screenshot strings, one of which lives in `superset/dashboards/api.py` on master but not in the committed template). This branch touches no translatable strings, so I've left it for a separate branch rather than pulling catalog churn in here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
